⊟
23.6 KB
/srv/reproducible-results/rbuild-debian/r-b-build.312We7K0/b1/apt_2.2.4_amd64.changes vs.
/srv/reproducible-results/rbuild-debian/r-b-build.312We7K0/b2/apt_2.2.4_amd64.changes
⊟
978 B
Files
    
Offset 2, 10 lines modifiedOffset 2, 10 lines modified
2 ·45da673bbf57aa1396104c8cfd7944c9·6766812·debug·optional·apt-dbgsym_2.2.4_amd64.deb2 ·45da673bbf57aa1396104c8cfd7944c9·6766812·debug·optional·apt-dbgsym_2.2.4_amd64.deb
3 ·3c9a8e3e348a2f965e0ef6a8ec6efed4·389020·doc·optional·apt-doc_2.2.4_all.deb3 ·3c9a8e3e348a2f965e0ef6a8ec6efed4·389020·doc·optional·apt-doc_2.2.4_all.deb
4 ·559b845daf8931dc41fb7f8f33c73afb·159640·oldlibs·optional·apt-transport-https_2.2.4_all.deb4 ·559b845daf8931dc41fb7f8f33c73afb·159640·oldlibs·optional·apt-transport-https_2.2.4_all.deb
5 ·b27553ae4e102cfd2f30a0aff4d6b954·1679788·debug·optional·apt-utils-dbgsym_2.2.4_amd64.deb5 ·b27553ae4e102cfd2f30a0aff4d6b954·1679788·debug·optional·apt-utils-dbgsym_2.2.4_amd64.deb
6 ·cd5ebb80ce64f1569d25e98d867bc704·439116·admin·important·apt-utils_2.2.4_amd64.deb6 ·cd5ebb80ce64f1569d25e98d867bc704·439116·admin·important·apt-utils_2.2.4_amd64.deb
7 ·d1172b59b7c4f76243bc046c3241eefc·1492024·admin·important·apt_2.2.4_amd64.deb7 ·d1172b59b7c4f76243bc046c3241eefc·1492024·admin·important·apt_2.2.4_amd64.deb
8 ·d6ba86a48eabf1988fe22ab717f37795·249204·libdevel·optional·libapt-pkg-dev_2.2.4_amd64.deb8 ·d6ba86a48eabf1988fe22ab717f37795·249204·libdevel·optional·libapt-pkg-dev_2.2.4_amd64.deb
9 ·e31b33f2712c6883518c7c1459a2e42c·971940·doc·optional·libapt-pkg-doc_2.2.4_all.deb9 ·499b595b1965043292c92ded2c782030·971920·doc·optional·libapt-pkg-doc_2.2.4_all.deb
10 ·1b2754dd991ff6e28ff8c65ab643e98f·9676728·debug·optional·libapt-pkg6.0-dbgsym_2.2.4_amd64.deb10 ·1b2754dd991ff6e28ff8c65ab643e98f·9676728·debug·optional·libapt-pkg6.0-dbgsym_2.2.4_amd64.deb
11 ·b54364a07d3dd3fb4c59795dbe559169·1012792·libs·optional·libapt-pkg6.0_2.2.4_amd64.deb11 ·b54364a07d3dd3fb4c59795dbe559169·1012792·libs·optional·libapt-pkg6.0_2.2.4_amd64.deb
⊟
22.5 KB
libapt-pkg-doc_2.2.4_all.deb
⊟
367 B
file list
    
Offset 1, 3 lines modifiedOffset 1, 3 lines modified
1 -rw-r--r--···0········0········0········4·2021-06-10·08:53:34.000000·debian-binary1 -rw-r--r--···0········0········0········4·2021-06-10·08:53:34.000000·debian-binary
2 -rw-r--r--···0········0········0····30668·2021-06-10·08:53:34.000000·control.tar.xz2 -rw-r--r--···0········0········0····30668·2021-06-10·08:53:34.000000·control.tar.xz
3 -rw-r--r--···0········0········0···941080·2021-06-10·08:53:34.000000·data.tar.xz3 -rw-r--r--···0········0········0···941060·2021-06-10·08:53:34.000000·data.tar.xz
⊟
98.0 B
control.tar.xz
⊟
70.0 B
control.tar
⊟
48.0 B
./md5sums
⊟
30.0 B
./md5sums
Files differ
⊟
22.0 KB
data.tar.xz
⊟
22.0 KB
data.tar
⊟
22.0 KB
./usr/share/doc/libapt-pkg-doc/html/todo.xhtml
    
Offset 43, 47 lines modifiedOffset 43, 51 lines modified
43 ··<div·class="headertitle">43 ··<div·class="headertitle">
44 <div·class="title">Todo·List·</div>··</div>44 <div·class="title">Todo·List·</div>··</div>
45 </div><!--header-->45 </div><!--header-->
46 <div·class="contents">46 <div·class="contents">
47 <div·class="textblock"><dl·class="reflist">47 <div·class="textblock"><dl·class="reflist">
48 <dt>Module·<a·class="el"·href="group__acquire.xhtml">acquire</a>··</dt>48 <dt>Module·<a·class="el"·href="group__acquire.xhtml">acquire</a>··</dt>
49 <dd><a·class="anchor"·id="_todo000016"></a>Acquire·supports·inserting·an·object·into·several·queues·at·once,·but·it·is·not·clear·what·its·behavior·in·this·case·is,·and·no·subclass·of·pkgAcquire::Item·seems·to·actually·use·this·capability.··</dd>49 <dd><a·class="anchor"·id="_todo000016"></a>Acquire·supports·inserting·an·object·into·several·queues·at·once,·but·it·is·not·clear·what·its·behavior·in·this·case·is,·and·no·subclass·of·pkgAcquire::Item·seems·to·actually·use·this·capability.··</dd>
 50 <dt>Member·<a·class="el"·href="classMMap.xhtml#abf6208ba8fc33da8217ee57b919c1892">MMap::Map</a>··(<a·class="el"·href="classFileFd.xhtml">FileFd</a>·&amp;Fd)</dt>
 51 <dd><a·class="anchor"·id="_todo000037"></a>Writing·to·compressed·fd's·?··</dd>
 52 <dt>Class·<a·class="el"·href="classpkgAcqIndex.xhtml">pkgAcqIndex</a>··</dt>
 53 <dd><a·class="anchor"·id="_todo000005"></a>Why·does·<a·class="el"·href="classpkgAcqIndex.xhtml"·title="An·acquire·item·that·is·responsible·for·fetching·an·index·{{{·file·(e.g.,·Packages·or·Sources).">pkgAcqIndex</a>·have·protected·members?··</dd>
 54 <dt>Class·<a·class="el"·href="classpkgAcqMetaSig.xhtml">pkgAcqMetaSig</a>··</dt>
 55 <dd><a·class="anchor"·id="_todo000004"></a>Why·protected·members?·</dd>
 56 <dt>Class·<a·class="el"·href="classpkgAcquire.xhtml">pkgAcquire</a>··</dt>
 57 <dd><p·class="startdd"><a·class="anchor"·id="_todo000018"></a>Why·so·many·protected·values?·</p>
 58 <p·class="interdd"><a·class="anchor"·id="_todo000017"></a>Why·all·the·protected·data·items·and·methods?·</p>
 59 <p·class="enddd"><a·class="anchor"·id="_todo000009"></a>Like·everything·else·in·the·Acquire·system,·this·has·way·too·many·protected·items.·</p>
 60 </dd>
 61 <dt>Member·<a·class="el"·href="classpkgCdrom.xhtml#a6d1bdb3f763da1f0a388888f206a50a6">pkgCdrom::Add</a>··(<a·class="el"·href="classpkgCdromStatus.xhtml">pkgCdromStatus</a>·*log)</dt>
 62 <dd><a·class="anchor"·id="_todo000034"></a>We·ignore·stat()·errors·here·as·we·usually·have·only·one·of·those·in·use··</dd>
 63 <dt>Member·<a·class="el"·href="classpkgDPkgPM.xhtml#a807efc750fd999dcd0e3a1c90f5684ca">pkgDPkgPM::Go</a>··(<a·class="el"·href="classAPT_1_1Progress_1_1PackageManager.xhtml">APT::Progress::PackageManager</a>·*progress)·APT_OVERRIDE</dt>
 64 <dd><a·class="anchor"·id="_todo000047"></a>workaround·for·dpkg·bug,·see·our·./test-bug-740843-versioned-up-down-breaks·test··</dd>
50 <dt>Member·<a·class="el"·href="classAPT_1_1CacheSetHelper.xhtml#ae746b3086d53d0a5ad666675cb003ef2">CacheSetHelper::PackageFromString</a>··(<a·class="el"·href="classAPT_1_1PackageContainerInterface.xhtml">PackageContainerInterface</a>·*const·pci,·<a·class="el"·href="classpkgCacheFile.xhtml">pkgCacheFile</a>·&amp;Cache,·std::string·const·&amp;pattern)</dt>65 <dt>Member·<a·class="el"·href="classAPT_1_1CacheSetHelper.xhtml#ae746b3086d53d0a5ad666675cb003ef2">CacheSetHelper::PackageFromString</a>··(<a·class="el"·href="classAPT_1_1PackageContainerInterface.xhtml">PackageContainerInterface</a>·*const·pci,·<a·class="el"·href="classpkgCacheFile.xhtml">pkgCacheFile</a>·&amp;Cache,·std::string·const·&amp;pattern)</dt>
51 <dd><a·class="anchor"·id="_todo000033"></a>hm,·hm,·regexp/fnmatch·incompatible?··</dd>66 <dd><a·class="anchor"·id="_todo000033"></a>hm,·hm,·regexp/fnmatch·incompatible?··</dd>
52 <dt>Member·<a·class="el"·href="classCommandLine.xhtml#ae95847c73c63fe09a42b29bb0525c14c">CommandLine::GetCommand</a>··(<a·class="el"·href="structCommandLine_1_1Dispatch.xhtml">Dispatch</a>·const·*const·Map,·unsigned·int·const·argc,·char·const·*const·*const·argv)·APT_PURE</dt>67 <dt>Member·<a·class="el"·href="classCommandLine.xhtml#ae95847c73c63fe09a42b29bb0525c14c">CommandLine::GetCommand</a>··(<a·class="el"·href="structCommandLine_1_1Dispatch.xhtml">Dispatch</a>·const·*const·Map,·unsigned·int·const·argc,·char·const·*const·*const·argv)·APT_PURE</dt>
53 <dd><a·class="anchor"·id="_todo000035"></a>How·like·is·it·that·an·option·parameter·will·be·also·a·valid·Match·?··</dd>68 <dd><a·class="anchor"·id="_todo000035"></a>How·like·is·it·that·an·option·parameter·will·be·also·a·valid·Match·?··</dd>
54 <dt>Member·<a·class="el"·href="classdebReleaseIndex.xhtml#aeaf2e9db914b9ddb21625a6172e5882f">debReleaseIndex::Load</a>··(std::string·const·&amp;Filename,·std::string·*const·ErrorText)·APT_OVERRIDE</dt>69 <dt>Member·<a·class="el"·href="classdebReleaseIndex.xhtml#aeaf2e9db914b9ddb21625a6172e5882f">debReleaseIndex::Load</a>··(std::string·const·&amp;Filename,·std::string·*const·ErrorText)·APT_OVERRIDE</dt>
55 <dd><a·class="anchor"·id="_todo000043"></a>find·better·tag·name··</dd>70 <dd><a·class="anchor"·id="_todo000043"></a>find·better·tag·name··</dd>
56 <dt>Member·<a·class="el"·href="classedspListParser.xhtml#a8a5b0770dc74cc79cd453d00021eb83b">edspListParser::ParseStatus</a>··(pkgCache::PkgIterator·&amp;Pkg,·pkgCache::VerIterator·&amp;Ver)·APT_OVERRIDE</dt>71 <dt>Member·<a·class="el"·href="classedspListParser.xhtml#a8a5b0770dc74cc79cd453d00021eb83b">edspListParser::ParseStatus</a>··(pkgCache::PkgIterator·&amp;Pkg,·pkgCache::VerIterator·&amp;Ver)·APT_OVERRIDE</dt>
57 <dd><a·class="anchor"·id="_todo000051"></a>Using·an·overriding·pin·is·wrong.··</dd>72 <dd><a·class="anchor"·id="_todo000051"></a>Using·an·overriding·pin·is·wrong.··</dd>
58 <dt>Member·<a·class="el"·href="classMMap.xhtml#abf6208ba8fc33da8217ee57b919c1892">MMap::Map</a>··(<a·class="el"·href="classFileFd.xhtml">FileFd</a>·&amp;Fd)</dt> 
59 <dd><a·class="anchor"·id="_todo000037"></a>Writing·to·compressed·fd's·?··</dd> 
60 <dt>Member·<a·class="el"·href="classAPT_1_1Progress_1_1PackageManagerFancy.xhtml#afdd3a4f5c1ff9a58b5588dd9da3ee4ec">PackageManagerFancy::GetTerminalSize</a>··()</dt>73 <dt>Member·<a·class="el"·href="classAPT_1_1Progress_1_1PackageManagerFancy.xhtml#afdd3a4f5c1ff9a58b5588dd9da3ee4ec">PackageManagerFancy::GetTerminalSize</a>··()</dt>
61 <dd><a·class="anchor"·id="_todo000056"></a>get·from·"child_pty"·instead?··</dd>74 <dd><a·class="anchor"·id="_todo000056"></a>get·from·"child_pty"·instead?··</dd>
62 <dt>Member·<a·class="el"·href="classAPT_1_1Progress_1_1PackageManagerProgressDeb822Fd.xhtml#a585ae4dbdec6a715a3ea524952da63e8">PackageManagerProgressDeb822Fd::StartDpkg</a>··()·APT_OVERRIDE</dt>75 <dt>Member·<a·class="el"·href="classAPT_1_1Progress_1_1PackageManagerProgressDeb822Fd.xhtml#a585ae4dbdec6a715a3ea524952da63e8">PackageManagerProgressDeb822Fd::StartDpkg</a>··()·APT_OVERRIDE</dt>
63 <dd><a·class="anchor"·id="_todo000055"></a>use·SetCloseExec·here·once·it·taught·about·throwing··</dd>76 <dd><a·class="anchor"·id="_todo000055"></a>use·SetCloseExec·here·once·it·taught·about·throwing··</dd>
64 <dt>Member·<a·class="el"·href="classAPT_1_1Progress_1_1PackageManagerProgressFd.xhtml#a585ae4dbdec6a715a3ea524952da63e8">PackageManagerProgressFd::StartDpkg</a>··()·APT_OVERRIDE</dt>77 <dt>Member·<a·class="el"·href="classAPT_1_1Progress_1_1PackageManagerProgressFd.xhtml#a585ae4dbdec6a715a3ea524952da63e8">PackageManagerProgressFd::StartDpkg</a>··()·APT_OVERRIDE</dt>
65 <dd><a·class="anchor"·id="_todo000054"></a>use·SetCloseExec·here·once·it·taught·about·throwing··</dd>78 <dd><a·class="anchor"·id="_todo000054"></a>use·SetCloseExec·here·once·it·taught·about·throwing··</dd>
66 <dt>Member·<a·class="el"·href="classpkgAcqDiffIndex.xhtml#a3980b570ebaa4972bbe5218ba6d3e32b">pkgAcqDiffIndex::ParseDiffIndex</a>··(std::string·const·&amp;IndexDiffFile)</dt>79 <dt>Member·<a·class="el"·href="classpkgAcqDiffIndex.xhtml#a3980b570ebaa4972bbe5218ba6d3e32b">pkgAcqDiffIndex::ParseDiffIndex</a>··(std::string·const·&amp;IndexDiffFile)</dt>
67 <dd><a·class="anchor"·id="_todo000003"></a>all·of·pdiff·supports·only·.gz·compressed·patches··</dd>80 <dd><a·class="anchor"·id="_todo000003"></a>all·of·pdiff·supports·only·.gz·compressed·patches··</dd>
68 <dt>Member·<a·class="el"·href="classpkgAcqDiffIndex.xhtml#a79496027fb5023578c8726a103bea532">pkgAcqDiffIndex::pkgAcqDiffIndex</a>··(<a·class="el"·href="classpkgAcquire.xhtml"·title="Represents·the·process·by·which·a·pkgAcquire·object·should·retrieve·a·file·or·a·collection·of·files.">pkgAcquire</a>·*const·Owner,·<a·class="el"·href="classpkgAcqMetaClearSig.xhtml"·title="An·item·responsible·for·downloading·clearsigned·metaindexes·{{{.">pkgAcqMetaClearSig</a>·*const·TransactionManager,·<a·class="el"·href="classIndexTarget.xhtml"·title="Information·about·an·index·file.">IndexTarget</a>·const·&amp;Target)·APT_NONNULL(2</dt>81 <dt>Member·<a·class="el"·href="classpkgAcqDiffIndex.xhtml#a79496027fb5023578c8726a103bea532">pkgAcqDiffIndex::pkgAcqDiffIndex</a>··(<a·class="el"·href="classpkgAcquire.xhtml"·title="Represents·the·process·by·which·a·pkgAcquire·object·should·retrieve·a·file·or·a·collection·of·files.">pkgAcquire</a>·*const·Owner,·<a·class="el"·href="classpkgAcqMetaClearSig.xhtml"·title="An·item·responsible·for·downloading·clearsigned·metaindexes·{{{.">pkgAcqMetaClearSig</a>·*const·TransactionManager,·<a·class="el"·href="classIndexTarget.xhtml"·title="Information·about·an·index·file.">IndexTarget</a>·const·&amp;Target)·APT_NONNULL(2</dt>
69 <dd><a·class="anchor"·id="_todo000002"></a>Magic·number·as·an·upper·bound·on·pdiffs·we·will·reasonably·acquire··</dd>82 <dd><a·class="anchor"·id="_todo000002"></a>Magic·number·as·an·upper·bound·on·pdiffs·we·will·reasonably·acquire··</dd>
70 <dt>Class·<a·class="el"·href="classpkgAcqIndex.xhtml">pkgAcqIndex</a>··</dt> 
71 <dd><a·class="anchor"·id="_todo000005"></a>Why·does·<a·class="el"·href="classpkgAcqIndex.xhtml"·title="An·acquire·item·that·is·responsible·for·fetching·an·index·{{{·file·(e.g.,·Packages·or·Sources).">pkgAcqIndex</a>·have·protected·members?··</dd> 
72 <dt>Member·<a·class="el"·href="classpkgAcqIndexDiffs.xhtml#a6822b4355d68d4683938302c3c4bee8b">pkgAcqIndexDiffs::available_patches</a>··</dt>83 <dt>Member·<a·class="el"·href="classpkgAcqIndexDiffs.xhtml#a6822b4355d68d4683938302c3c4bee8b">pkgAcqIndexDiffs::available_patches</a>··</dt>
73 <dd><a·class="anchor"·id="_todo000006"></a>These·are·indexed·by·sha1sum;·why·not·use·some·sort·of·dictionary·instead·of·relying·on·ordering·and·stripping·them·off·the·front?··</dd>84 <dd><a·class="anchor"·id="_todo000006"></a>These·are·indexed·by·sha1sum;·why·not·use·some·sort·of·dictionary·instead·of·relying·on·ordering·and·stripping·them·off·the·front?··</dd>
74 <dt>Class·<a·class="el"·href="classpkgAcqMetaSig.xhtml">pkgAcqMetaSig</a>··</dt> 
75 <dd><a·class="anchor"·id="_todo000004"></a>Why·protected·members?·</dd> 
76 <dt>Member·<a·class="el"·href="classpkgAcqMetaSig.xhtml#a3f0cc0b4b3be0867c4412bf15c3f7043">pkgAcqMetaSig::Failed</a>··(std::string·const·&amp;Message,·<a·class="el"·href="classpkgAcquire.xhtml#a29c0cb60fa0c1e5f67d911bed92f2006"·title="Set·up·the·default·method·parameters.">pkgAcquire::MethodConfig</a>·const·*const·Cnf)·APT_OVERRIDE</dt>85 <dt>Member·<a·class="el"·href="classpkgAcqMetaSig.xhtml#a3f0cc0b4b3be0867c4412bf15c3f7043">pkgAcqMetaSig::Failed</a>··(std::string·const·&amp;Message,·<a·class="el"·href="classpkgAcquire.xhtml#a29c0cb60fa0c1e5f67d911bed92f2006"·title="Set·up·the·default·method·parameters.">pkgAcquire::MethodConfig</a>·const·*const·Cnf)·APT_OVERRIDE</dt>
77 <dd><a·class="anchor"·id="_todo000001"></a>this·is·used·often·(e.g.·in·pkgAcqIndexTrans)·so·refactor··</dd>86 <dd><a·class="anchor"·id="_todo000001"></a>this·is·used·often·(e.g.·in·pkgAcqIndexTrans)·so·refactor··</dd>
78 <dt>Class·<a·class="el"·href="classpkgAcquire.xhtml">pkgAcquire</a>··</dt> 
79 <dd><p·class="startdd"><a·class="anchor"·id="_todo000017"></a>Why·all·the·protected·data·items·and·methods?·</p> 
80 <p·class="interdd"><a·class="anchor"·id="_todo000018"></a>Why·so·many·protected·values?·</p> 
81 <p·class="enddd"><a·class="anchor"·id="_todo000009"></a>Like·everything·else·in·the·Acquire·system,·this·has·way·too·many·protected·items.·</p> 
82 </dd> 
83 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a006a979c4801f6b6ceb33cb3acd6dc89">pkgAcquire::Access</a>··</dt>87 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a006a979c4801f6b6ceb33cb3acd6dc89">pkgAcquire::Access</a>··</dt>
84 <dd><a·class="anchor"·id="_todo000011"></a>Doesn't·this·duplicate·Config-&gt;Access?··</dd>88 <dd><a·class="anchor"·id="_todo000011"></a>Doesn't·this·duplicate·Config-&gt;Access?··</dd>
85 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#abf4fe627ab803887ecd2a8af30f17147">pkgAcquire::Bump</a>··()</dt>89 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#abf4fe627ab803887ecd2a8af30f17147">pkgAcquire::Bump</a>··()</dt>
86 <dd><a·class="anchor"·id="_todo000027"></a>Why·both·this·and·<a·class="el"·href="classpkgAcquire.xhtml#a5b2dd956b1adc90b13d47e26121d5486"·title="Send·idle·items·to·the·worker·process.">Cycle()</a>?·Are·they·expected·to·be·different·someday?··</dd>90 <dd><a·class="anchor"·id="_todo000027"></a>Why·both·this·and·<a·class="el"·href="classpkgAcquire.xhtml#a5b2dd956b1adc90b13d47e26121d5486"·title="Send·idle·items·to·the·worker·process.">Cycle()</a>?·Are·they·expected·to·be·different·someday?··</dd>
87 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#ab04e9ee398f825f50e4f1ea7eaf37f77">pkgAcquire::Configs</a>··</dt>91 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#ab04e9ee398f825f50e4f1ea7eaf37f77">pkgAcquire::Configs</a>··</dt>
88 <dd><a·class="anchor"·id="_todo000022"></a>why·a·hand-managed·config·dictionary·instead·of·std::map?··</dd>92 <dd><a·class="anchor"·id="_todo000022"></a>why·a·hand-managed·config·dictionary·instead·of·std::map?··</dd>
89 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a849bc65c54e1bcbe8a7f053ce2cec672">pkgAcquire::InReady</a>··</dt>93 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a849bc65c54e1bcbe8a7f053ce2cec672">pkgAcquire::InReady</a>··</dt>
Offset 100, 18 lines modifiedOffset 104, 18 lines modified
100 <dd><a·class="anchor"·id="_todo000014"></a>Wouldn't·a·std::dequeue·be·more·appropriate?··</dd>104 <dd><a·class="anchor"·id="_todo000014"></a>Wouldn't·a·std::dequeue·be·more·appropriate?··</dd>
101 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a0b8717fb6d062212c251900cee4e6004">pkgAcquire::OutReady</a>··</dt>105 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a0b8717fb6d062212c251900cee4e6004">pkgAcquire::OutReady</a>··</dt>
102 <dd><a·class="anchor"·id="_todo000013"></a>Is·this·right?··</dd>106 <dd><a·class="anchor"·id="_todo000013"></a>Is·this·right?··</dd>
103 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a9e42b66f176afafc1c75e78289e80e76">pkgAcquire::Queues</a>··</dt>107 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a9e42b66f176afafc1c75e78289e80e76">pkgAcquire::Queues</a>··</dt>
104 <dd><a·class="anchor"·id="_todo000020"></a>why·a·hand-managed·list·of·queues·instead·of·std::list·or·std::set?··</dd>108 <dd><a·class="anchor"·id="_todo000020"></a>why·a·hand-managed·list·of·queues·instead·of·std::list·or·std::set?··</dd>
105 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a26a68d57a249a042c1e32186ce2fce8b">pkgAcquire::RunMessages</a>··()</dt>109 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#a26a68d57a249a042c1e32186ce2fce8b">pkgAcquire::RunMessages</a>··()</dt>
106 <dd><a·class="anchor"·id="_todo000015"></a>Several·message·types·lack·separate·handlers.·</dd>110 <dd><a·class="anchor"·id="_todo000015"></a>Several·message·types·lack·separate·handlers.·</dd>
107 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#ae49de4816f8591cf1ccb70329d4dcb8c">pkgAcquire::Workers</a>··</dt>111 <dt>Member·<a·class="el"·href="classpkgAcquire.xhtml#adfb69296d9a50a92927df7c30e56be2e">pkgAcquire::Workers</a>··</dt>
108 <dd><p·class="startdd"><a·class="anchor"·id="_todo000025"></a>Why·not·just·use·a·std::set?·</p> 
109 <p·class="interdd"><a·class="anchor"·id="_todo000021"></a>why·a·hand-managed·list·of·workers·instead·of·std::list·or·std::set?·</p>112 <dd><p·class="startdd"><a·class="anchor"·id="_todo000021"></a>why·a·hand-managed·list·of·workers·instead·of·std::list·or·std::set?·</p>
110 <p·class="enddd"><a·class="anchor"·id="_todo000024"></a>This·is·plural·because·support·exists·in·Queue·for·multiple·workers.·However,·it·does·not·appear·that·there·is·any·way·to·actually·associate·more·than·one·worker·with·a·queue.·</p>113 <p·class="interdd"><a·class="anchor"·id="_todo000024"></a>This·is·plural·because·support·exists·in·Queue·for·multiple·workers.·However,·it·does·not·appear·that·there·is·any·way·to·actually·associate·more·than·one·worker·with·a·queue.</p>
 114 <p·class="enddd"><a·class="anchor"·id="_todo000025"></a>Why·not·just·use·a·std::set?··</p>
111 </dd>115 </dd>
112 <dt>Class·<a·class="el"·href="classpkgAcquireStatus.xhtml">pkgAcquireStatus</a>··</dt>116 <dt>Class·<a·class="el"·href="classpkgAcquireStatus.xhtml">pkgAcquireStatus</a>··</dt>
113 <dd><a·class="anchor"·id="_todo000019"></a>Why·protected·members?··</dd>117 <dd><a·class="anchor"·id="_todo000019"></a>Why·protected·members?··</dd>
114 <dt>Member·<a·class="el"·href="classpkgAcquireStatus.xhtml#a61c6f568f6582836223430d117a62e69">pkgAcquireStatus::MediaChange</a>··(std::string·Media,·std::string·Drive)=0</dt>118 <dt>Member·<a·class="el"·href="classpkgAcquireStatus.xhtml#a61c6f568f6582836223430d117a62e69">pkgAcquireStatus::MediaChange</a>··(std::string·Media,·std::string·Drive)=0</dt>
115 <dd><a·class="anchor"·id="_todo000029"></a>This·is·a·horrible·blocking·monster;·it·should·be·CPSed·with·prejudice.··</dd>119 <dd><a·class="anchor"·id="_todo000029"></a>This·is·a·horrible·blocking·monster;·it·should·be·CPSed·with·prejudice.··</dd>
116 <dt>Member·<a·class="el"·href="structpkgCache_1_1DescFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache&lt;·Str,·Itr·&gt;::DescFile::Size</a>··</dt>120 <dt>Member·<a·class="el"·href="structpkgCache_1_1DescFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache&lt;·Str,·Itr·&gt;::DescFile::Size</a>··</dt>
117 <dd><a·class="anchor"·id="_todo000063"></a>document·<a·class="el"·href="structpkgCache_1_1DescFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache::DescFile::Size</a>··</dd>121 <dd><a·class="anchor"·id="_todo000063"></a>document·<a·class="el"·href="structpkgCache_1_1DescFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache::DescFile::Size</a>··</dd>
Offset 123, 31 lines modifiedOffset 127, 27 lines modified
123 <dd><a·class="anchor"·id="_todo000060"></a>enumerate·at·least·the·possible·indexes··</dd>127 <dd><a·class="anchor"·id="_todo000060"></a>enumerate·at·least·the·possible·indexes··</dd>
124 <dt>Member·<a·class="el"·href="structpkgCache_1_1ReleaseFile.xhtml#a87b9212b05c48e953f3d476eee0a3595">pkgCache&lt;·Str,·Itr·&gt;::ReleaseFile::Flags</a>··</dt>128 <dt>Member·<a·class="el"·href="structpkgCache_1_1ReleaseFile.xhtml#a87b9212b05c48e953f3d476eee0a3595">pkgCache&lt;·Str,·Itr·&gt;::ReleaseFile::Flags</a>··</dt>
125 <dd><a·class="anchor"·id="_todo000059"></a>document·<a·class="el"·href="structpkgCache_1_1PackageFile.xhtml#a87b9212b05c48e953f3d476eee0a3595">PackageFile::Flags</a>··</dd>129 <dd><a·class="anchor"·id="_todo000059"></a>document·<a·class="el"·href="structpkgCache_1_1PackageFile.xhtml#a87b9212b05c48e953f3d476eee0a3595">PackageFile::Flags</a>··</dd>
126 <dt>Member·<a·class="el"·href="structpkgCache_1_1VerFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache&lt;·Str,·Itr·&gt;::VerFile::Size</a>··</dt>130 <dt>Member·<a·class="el"·href="structpkgCache_1_1VerFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache&lt;·Str,·Itr·&gt;::VerFile::Size</a>··</dt>
127 <dd><a·class="anchor"·id="_todo000062"></a>document·<a·class="el"·href="structpkgCache_1_1VerFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache::VerFile::Size</a>··</dd>131 <dd><a·class="anchor"·id="_todo000062"></a>document·<a·class="el"·href="structpkgCache_1_1VerFile.xhtml#a924e1d37050236e62bcb18be0c5e5f0f">pkgCache::VerFile::Size</a>··</dd>
128 <dt>Member·<a·class="el"·href="classpkgCacheGenerator.xhtml#a69c67e48848ceba8d57db704c03875e8">pkgCacheGenerator::MakeStatusCache</a>··(<a·class="el"·href="classpkgSourceList.xhtml">pkgSourceList</a>·&amp;List,·<a·class="el"·href="classOpProgress.xhtml">OpProgress</a>·*Progress,·<a·class="el"·href="classMMap.xhtml">MMap</a>·**OutMap,·<a·class="el"·href="classpkgCache.xhtml">pkgCache</a>·**OutCache,·bool·AllowMem=false)</dt>132 <dt>Member·<a·class="el"·href="classpkgCacheGenerator.xhtml#a69c67e48848ceba8d57db704c03875e8">pkgCacheGenerator::MakeStatusCache</a>··(<a·class="el"·href="classpkgSourceList.xhtml">pkgSourceList</a>·&amp;List,·<a·class="el"·href="classOpProgress.xhtml">OpProgress</a>·*Progress,·<a·class="el"·href="classMMap.xhtml">MMap</a>·**OutMap,·<a·class="el"·href="classpkgCache.xhtml">pkgCache</a>·**OutCache,·bool·AllowMem=false)</dt>
129 <dd><a·class="anchor"·id="_todo000065"></a>deprecate·the·ignored·AllowMem·parameter··</dd>133 <dd><a·class="anchor"·id="_todo000065"></a>deprecate·the·ignored·AllowMem·parameter··</dd>
130 <dt>Member·<a·class="el"·href="classpkgCdrom.xhtml#a6d1bdb3f763da1f0a388888f206a50a6">pkgCdrom::Add</a>··(<a·class="el"·href="classpkgCdromStatus.xhtml">pkgCdromStatus</a>·*log)</dt> 
131 <dd><a·class="anchor"·id="_todo000034"></a>We·ignore·stat()·errors·here·as·we·usually·have·only·one·of·those·in·use··</dd> 
132 <dt>Member·<a·class="el"·href="classpkgDepCache.xhtml#a1ab9378572dc74fc8088fd690d494570">pkgDepCache::GetRootSetFunc</a>··()</dt>134 <dt>Member·<a·class="el"·href="classpkgDepCache.xhtml#a1ab9378572dc74fc8088fd690d494570">pkgDepCache::GetRootSetFunc</a>··()</dt>
133 <dd><a·class="anchor"·id="_todo000050"></a>Is·this·the·best·place·for·this·function?·Perhaps·the·settings·for·mark-and-sweep·should·be·stored·in·a·single·external·class?··</dd>135 <dd><a·class="anchor"·id="_todo000050"></a>Is·this·the·best·place·for·this·function?·Perhaps·the·settings·for·mark-and-sweep·should·be·stored·in·a·single·external·class?··</dd>
134 <dt>Member·<a·class="el"·href="classpkgDepCache_1_1Policy.xhtml#a6ab9cf0a0e662622e47d3fe99cafc817">pkgDepCache::Policy::IsImportantDep</a>··(DepIterator·const·&amp;Dep)·const</dt>136 <dt>Member·<a·class="el"·href="classpkgDepCache_1_1Policy.xhtml#a6ab9cf0a0e662622e47d3fe99cafc817">pkgDepCache::Policy::IsImportantDep</a>··(DepIterator·const·&amp;Dep)·const</dt>
135 <dd><a·class="anchor"·id="_todo000049"></a>this·is·a·meant·as·a·temporary·solution·until·the··</dd>137 <dd><a·class="anchor"·id="_todo000049"></a>this·is·a·meant·as·a·temporary·solution·until·the··</dd>
136 <dt>Member·<a·class="el"·href="classpkgDPkgPM.xhtml#a807efc750fd999dcd0e3a1c90f5684ca">pkgDPkgPM::Go</a>··(<a·class="el"·href="classAPT_1_1Progress_1_1PackageManager.xhtml">APT::Progress::PackageManager</a>·*progress)·APT_OVERRIDE</dt> 
137 <dd><a·class="anchor"·id="_todo000047"></a>workaround·for·dpkg·bug,·see·our·./test-bug-740843-versioned-up-down-breaks·test··</dd> 
138 <dt>Member·<a·class="el"·href="classpkgDPkgPM.xhtml#a367828235aced7bf124b0cd6827d9a2d">pkgDPkgPM::OpenLog</a>··()</dt>138 <dt>Member·<a·class="el"·href="classpkgDPkgPM.xhtml#a367828235aced7bf124b0cd6827d9a2d">pkgDPkgPM::OpenLog</a>··()</dt>
139 <dd><a·class="anchor"·id="_todo000046"></a>use·a·better·string·after·freeze··</dd>139 <dd><a·class="anchor"·id="_todo000046"></a>use·a·better·string·after·freeze··</dd>
140 <dt>Member·<a·class="el"·href="classpkgDPkgPM.xhtml#a6be54fa1743a469c0119ed27ee6e1087">pkgDPkgPM::ProcessDpkgStatusLine</a>··(char·*line)</dt>140 <dt>Member·<a·class="el"·href="classpkgDPkgPM.xhtml#a6be54fa1743a469c0119ed27ee6e1087">pkgDPkgPM::ProcessDpkgStatusLine</a>··(char·*line)</dt>
 141 <dd><p·class="startdd"><a·class="anchor"·id="_todo000044"></a>this·needs·a·muliarch·testcase·</p>
141 <dd><p·class="startdd"><a·class="anchor"·id="_todo000045"></a>2:·is·"pkgname"·here·reliable·with·dpkg·only·sending·us·</p>142 <p·class="enddd"><a·class="anchor"·id="_todo000045"></a>2:·is·"pkgname"·here·reliable·with·dpkg·only·sending·us··</p>
142 <p·class="enddd"><a·class="anchor"·id="_todo000044"></a>this·needs·a·muliarch·testcase··</p> 
143 </dd>143 </dd>
144 <dt>Member·<a·class="el"·href="classpkgPackageManager.xhtml#aeca45edd4cb610fe7e7c1d39ed110b03">pkgPackageManager::EarlyRemove</a>··(PkgIterator·Pkg,·DepIterator·const·*const·Dep)·APT_MUSTCHECK</dt>144 <dt>Member·<a·class="el"·href="classpkgPackageManager.xhtml#aeca45edd4cb610fe7e7c1d39ed110b03">pkgPackageManager::EarlyRemove</a>··(PkgIterator·Pkg,·DepIterator·const·*const·Dep)·APT_MUSTCHECK</dt>
145 <dd><p·class="startdd"><a·class="anchor"·id="_todo000057"></a>Unify·messaging·with·Protected·below.·</p> 
146 <p·class="enddd"><a·class="anchor"·id="_todo000058"></a>Message·should·talk·about·Protected,·not·Essential,·and·unified.··</p>145 <dd><p·class="startdd"><a·class="anchor"·id="_todo000058"></a>Message·should·talk·about·Protected,·not·Essential,·and·unified.·</p>
 146 <p·class="enddd"><a·class="anchor"·id="_todo000057"></a>Unify·messaging·with·Protected·below.··</p>
147 </dd>147 </dd>
148 <dt>Member·<a·class="el"·href="classpkgPolicy.xhtml#a09125a1b5560d8c43c8e669560663a7d">pkgPolicy::pkgPolicy</a>··(<a·class="el"·href="classpkgCache.xhtml">pkgCache</a>·*Owner)</dt>148 <dt>Member·<a·class="el"·href="classpkgPolicy.xhtml#a09125a1b5560d8c43c8e669560663a7d">pkgPolicy::pkgPolicy</a>··(<a·class="el"·href="classpkgCache.xhtml">pkgCache</a>·*Owner)</dt>
149 <dd><a·class="anchor"·id="_todo000067"></a>make·ExpressionMatches·static·to·use·it·here·easily··</dd>149 <dd><a·class="anchor"·id="_todo000067"></a>make·ExpressionMatches·static·to·use·it·here·easily··</dd>
150 <dt>Member·<a·class="el"·href="classpkgProblemResolver.xhtml#a4e1bfb762b1ddbf737d74663852aeafa">pkgProblemResolver::ResolveInternal</a>··(bool·const·BrokenFix=false)</dt>150 <dt>Member·<a·class="el"·href="classpkgProblemResolver.xhtml#a4e1bfb762b1ddbf737d74663852aeafa">pkgProblemResolver::ResolveInternal</a>··(bool·const·BrokenFix=false)</dt>
151 <dd><p·class="startdd"><a·class="anchor"·id="_todo000030"></a>we·should·undo·the·complete·MarkInstall·process·here·</p>151 <dd><p·class="startdd"><a·class="anchor"·id="_todo000030"></a>we·should·undo·the·complete·MarkInstall·process·here·</p>
152 <p·class="enddd"><a·class="anchor"·id="_todo000031"></a>use·DoUpgrade(Pkg)·instead?··</p>152 <p·class="enddd"><a·class="anchor"·id="_todo000031"></a>use·DoUpgrade(Pkg)·instead?··</p>
153 </dd>153 </dd>
⊟
6.33 KB
html2text {}
    
Offset 6, 55 lines modifiedOffset 6, 60 lines modified
6 commandline·package·manager6 commandline·package·manager
  
7 Todo·List7 Todo·List
8 ··Module·acquire8 ··Module·acquire
9 ······Acquire·supports·inserting·an·object·into·several·queues·at·once,·but·it9 ······Acquire·supports·inserting·an·object·into·several·queues·at·once,·but·it
10 ······is·not·clear·what·its·behavior·in·this·case·is,·and·no·subclass·of10 ······is·not·clear·what·its·behavior·in·this·case·is,·and·no·subclass·of
11 ······pkgAcquire::Item·seems·to·actually·use·this·capability.11 ······pkgAcquire::Item·seems·to·actually·use·this·capability.
 12 ··Member·MMap::Map·(FileFd·&Fd)
 13 ······Writing·to·compressed·fd's·?
 14 ··Class·pkgAcqIndex
 15 ······Why·does·pkgAcqIndex·have·protected·members?
 16 ··Class·pkgAcqMetaSig
 17 ······Why·protected·members?
 18 ··Class·pkgAcquire
 19 ······Why·so·many·protected·values?
 20 ······Why·all·the·protected·data·items·and·methods?
 21 ······Like·everything·else·in·the·Acquire·system,·this·has·way·too·many
 22 ······protected·items.
 23 ··Member·pkgCdrom::Add·(pkgCdromStatus·*log)
 24 ······We·ignore·stat()·errors·here·as·we·usually·have·only·one·of·those·in·use
 25 ··Member·pkgDPkgPM::Go·(APT::Progress::PackageManager·*progress)·APT_OVERRIDE
 26 ······workaround·for·dpkg·bug,·see·our·./test-bug-740843-versioned-up-down-
 27 ······breaks·test
12 ··Member·CacheSetHelper::PackageFromString·(PackageContainerInterface·*const28 ··Member·CacheSetHelper::PackageFromString·(PackageContainerInterface·*const
13 ··pci,·pkgCacheFile·&Cache,·std::string·const·&pattern)29 ··pci,·pkgCacheFile·&Cache,·std::string·const·&pattern)
14 ······hm,·hm,·regexp/fnmatch·incompatible?30 ······hm,·hm,·regexp/fnmatch·incompatible?
15 ··Member·CommandLine::GetCommand·(Dispatch·const·*const·Map,·unsigned·int·const31 ··Member·CommandLine::GetCommand·(Dispatch·const·*const·Map,·unsigned·int·const
16 ··argc,·char·const·*const·*const·argv)·APT_PURE32 ··argc,·char·const·*const·*const·argv)·APT_PURE
17 ······How·like·is·it·that·an·option·parameter·will·be·also·a·valid·Match·?33 ······How·like·is·it·that·an·option·parameter·will·be·also·a·valid·Match·?
18 ··Member·debReleaseIndex::Load·(std::string·const·&Filename,·std::string·*const34 ··Member·debReleaseIndex::Load·(std::string·const·&Filename,·std::string·*const
19 ··ErrorText)·APT_OVERRIDE35 ··ErrorText)·APT_OVERRIDE
20 ······find·better·tag·name36 ······find·better·tag·name
21 ··Member·edspListParser::ParseStatus·(pkgCache::PkgIterator·&Pkg,·pkgCache::37 ··Member·edspListParser::ParseStatus·(pkgCache::PkgIterator·&Pkg,·pkgCache::
22 ··VerIterator·&Ver)·APT_OVERRIDE38 ··VerIterator·&Ver)·APT_OVERRIDE
23 ······Using·an·overriding·pin·is·wrong.39 ······Using·an·overriding·pin·is·wrong.
24 ··Member·MMap::Map·(FileFd·&Fd) 
25 ······Writing·to·compressed·fd's·? 
26 ··Member·PackageManagerFancy::GetTerminalSize·()40 ··Member·PackageManagerFancy::GetTerminalSize·()
27 ······get·from·"child_pty"·instead?41 ······get·from·"child_pty"·instead?
28 ··Member·PackageManagerProgressDeb822Fd::StartDpkg·()·APT_OVERRIDE42 ··Member·PackageManagerProgressDeb822Fd::StartDpkg·()·APT_OVERRIDE
29 ······use·SetCloseExec·here·once·it·taught·about·throwing43 ······use·SetCloseExec·here·once·it·taught·about·throwing
30 ··Member·PackageManagerProgressFd::StartDpkg·()·APT_OVERRIDE44 ··Member·PackageManagerProgressFd::StartDpkg·()·APT_OVERRIDE
31 ······use·SetCloseExec·here·once·it·taught·about·throwing45 ······use·SetCloseExec·here·once·it·taught·about·throwing
32 ··Member·pkgAcqDiffIndex::ParseDiffIndex·(std::string·const·&IndexDiffFile)46 ··Member·pkgAcqDiffIndex::ParseDiffIndex·(std::string·const·&IndexDiffFile)
33 ······all·of·pdiff·supports·only·.gz·compressed·patches47 ······all·of·pdiff·supports·only·.gz·compressed·patches
34 ··Member·pkgAcqDiffIndex::pkgAcqDiffIndex·(pkgAcquire·*const·Owner,48 ··Member·pkgAcqDiffIndex::pkgAcqDiffIndex·(pkgAcquire·*const·Owner,
35 ··pkgAcqMetaClearSig·*const·TransactionManager,·IndexTarget·const·&Target)49 ··pkgAcqMetaClearSig·*const·TransactionManager,·IndexTarget·const·&Target)
36 ··APT_NONNULL(250 ··APT_NONNULL(2
37 ······Magic·number·as·an·upper·bound·on·pdiffs·we·will·reasonably·acquire51 ······Magic·number·as·an·upper·bound·on·pdiffs·we·will·reasonably·acquire
38 ··Class·pkgAcqIndex 
39 ······Why·does·pkgAcqIndex·have·protected·members? 
40 ··Member·pkgAcqIndexDiffs::available_patches52 ··Member·pkgAcqIndexDiffs::available_patches
41 ······These·are·indexed·by·sha1sum;·why·not·use·some·sort·of·dictionary·instead53 ······These·are·indexed·by·sha1sum;·why·not·use·some·sort·of·dictionary·instead
42 ······of·relying·on·ordering·and·stripping·them·off·the·front?54 ······of·relying·on·ordering·and·stripping·them·off·the·front?
43 ··Class·pkgAcqMetaSig 
44 ······Why·protected·members? 
45 ··Member·pkgAcqMetaSig::Failed·(std::string·const·&Message,·pkgAcquire::55 ··Member·pkgAcqMetaSig::Failed·(std::string·const·&Message,·pkgAcquire::
46 ··MethodConfig·const·*const·Cnf)·APT_OVERRIDE56 ··MethodConfig·const·*const·Cnf)·APT_OVERRIDE
47 ······this·is·used·often·(e.g.·in·pkgAcqIndexTrans)·so·refactor57 ······this·is·used·often·(e.g.·in·pkgAcqIndexTrans)·so·refactor
48 ··Class·pkgAcquire 
49 ······Why·all·the·protected·data·items·and·methods? 
50 ······Why·so·many·protected·values? 
51 ······Like·everything·else·in·the·Acquire·system,·this·has·way·too·many 
52 ······protected·items. 
53 ··Member·pkgAcquire::Access58 ··Member·pkgAcquire::Access
54 ······Doesn't·this·duplicate·Config->Access?59 ······Doesn't·this·duplicate·Config->Access?
55 ··Member·pkgAcquire::Bump·()60 ··Member·pkgAcquire::Bump·()
56 ······Why·both·this·and·Cycle()?·Are·they·expected·to·be·different·someday?61 ······Why·both·this·and·Cycle()?·Are·they·expected·to·be·different·someday?
57 ··Member·pkgAcquire::Configs62 ··Member·pkgAcquire::Configs
58 ······why·a·hand-managed·config·dictionary·instead·of·std::map?63 ······why·a·hand-managed·config·dictionary·instead·of·std::map?
59 ··Member·pkgAcquire::InReady64 ··Member·pkgAcquire::InReady
Offset 72, 19 lines modifiedOffset 77, 19 lines modified
72 ··Member·pkgAcquire::OutReady77 ··Member·pkgAcquire::OutReady
73 ······Is·this·right?78 ······Is·this·right?
74 ··Member·pkgAcquire::Queues79 ··Member·pkgAcquire::Queues
75 ······why·a·hand-managed·list·of·queues·instead·of·std::list·or·std::set?80 ······why·a·hand-managed·list·of·queues·instead·of·std::list·or·std::set?
76 ··Member·pkgAcquire::RunMessages·()81 ··Member·pkgAcquire::RunMessages·()
77 ······Several·message·types·lack·separate·handlers.82 ······Several·message·types·lack·separate·handlers.
78 ··Member·pkgAcquire::Workers83 ··Member·pkgAcquire::Workers
79 ······Why·not·just·use·a·std::set? 
80 ······why·a·hand-managed·list·of·workers·instead·of·std::list·or·std::set?84 ······why·a·hand-managed·list·of·workers·instead·of·std::list·or·std::set?
81 ······This·is·plural·because·support·exists·in·Queue·for·multiple·workers.85 ······This·is·plural·because·support·exists·in·Queue·for·multiple·workers.
82 ······However,·it·does·not·appear·that·there·is·any·way·to·actually·associate86 ······However,·it·does·not·appear·that·there·is·any·way·to·actually·associate
83 ······more·than·one·worker·with·a·queue.87 ······more·than·one·worker·with·a·queue.
 88 ······Why·not·just·use·a·std::set?
84 ··Class·pkgAcquireStatus89 ··Class·pkgAcquireStatus
85 ······Why·protected·members?90 ······Why·protected·members?
86 ··Member·pkgAcquireStatus::MediaChange·(std::string·Media,·std::string·Drive)=091 ··Member·pkgAcquireStatus::MediaChange·(std::string·Media,·std::string·Drive)=0
87 ······This·is·a·horrible·blocking·monster;·it·should·be·CPSed·with·prejudice.92 ······This·is·a·horrible·blocking·monster;·it·should·be·CPSed·with·prejudice.
88 ··Member·pkgCache<_Str,_Itr_>::DescFile::Size93 ··Member·pkgCache<_Str,_Itr_>::DescFile::Size
89 ······document·pkgCache::DescFile::Size94 ······document·pkgCache::DescFile::Size
90 ··Member·pkgCache<_Str,_Itr_>::Description::FileList95 ··Member·pkgCache<_Str,_Itr_>::Description::FileList
Offset 96, 33 lines modifiedOffset 101, 28 lines modified
96 ··Member·pkgCache<_Str,_Itr_>::ReleaseFile::Flags101 ··Member·pkgCache<_Str,_Itr_>::ReleaseFile::Flags
97 ······document·PackageFile::Flags102 ······document·PackageFile::Flags
98 ··Member·pkgCache<_Str,_Itr_>::VerFile::Size103 ··Member·pkgCache<_Str,_Itr_>::VerFile::Size
99 ······document·pkgCache::VerFile::Size104 ······document·pkgCache::VerFile::Size
100 ··Member·pkgCacheGenerator::MakeStatusCache·(pkgSourceList·&List,·OpProgress105 ··Member·pkgCacheGenerator::MakeStatusCache·(pkgSourceList·&List,·OpProgress
101 ··*Progress,·MMap·**OutMap,·pkgCache·**OutCache,·bool·AllowMem=false)106 ··*Progress,·MMap·**OutMap,·pkgCache·**OutCache,·bool·AllowMem=false)
102 ······deprecate·the·ignored·AllowMem·parameter107 ······deprecate·the·ignored·AllowMem·parameter
103 ··Member·pkgCdrom::Add·(pkgCdromStatus·*log) 
104 ······We·ignore·stat()·errors·here·as·we·usually·have·only·one·of·those·in·use 
105 ··Member·pkgDepCache::GetRootSetFunc·()108 ··Member·pkgDepCache::GetRootSetFunc·()
106 ······Is·this·the·best·place·for·this·function?·Perhaps·the·settings·for·mark-109 ······Is·this·the·best·place·for·this·function?·Perhaps·the·settings·for·mark-
107 ······and-sweep·should·be·stored·in·a·single·external·class?110 ······and-sweep·should·be·stored·in·a·single·external·class?
108 ··Member·pkgDepCache::Policy::IsImportantDep·(DepIterator·const·&Dep)·const111 ··Member·pkgDepCache::Policy::IsImportantDep·(DepIterator·const·&Dep)·const
109 ······this·is·a·meant·as·a·temporary·solution·until·the112 ······this·is·a·meant·as·a·temporary·solution·until·the
110 ··Member·pkgDPkgPM::Go·(APT::Progress::PackageManager·*progress)·APT_OVERRIDE 
111 ······workaround·for·dpkg·bug,·see·our·./test-bug-740843-versioned-up-down- 
112 ······breaks·test 
113 ··Member·pkgDPkgPM::OpenLog·()113 ··Member·pkgDPkgPM::OpenLog·()
114 ······use·a·better·string·after·freeze114 ······use·a·better·string·after·freeze
115 ··Member·pkgDPkgPM::ProcessDpkgStatusLine·(char·*line)115 ··Member·pkgDPkgPM::ProcessDpkgStatusLine·(char·*line)
116 ······2:·is·"pkgname"·here·reliable·with·dpkg·only·sending·us 
117 ······this·needs·a·muliarch·testcase116 ······this·needs·a·muliarch·testcase
 117 ······2:·is·"pkgname"·here·reliable·with·dpkg·only·sending·us
118 ··Member·pkgPackageManager::EarlyRemove·(PkgIterator·Pkg,·DepIterator·const118 ··Member·pkgPackageManager::EarlyRemove·(PkgIterator·Pkg,·DepIterator·const
119 ··*const·Dep)·APT_MUSTCHECK119 ··*const·Dep)·APT_MUSTCHECK
120 ······Unify·messaging·with·Protected·below. 
121 ······Message·should·talk·about·Protected,·not·Essential,·and·unified.120 ······Message·should·talk·about·Protected,·not·Essential,·and·unified.
 121 ······Unify·messaging·with·Protected·below.
122 ··Member·pkgPolicy::pkgPolicy·(pkgCache·*Owner)122 ··Member·pkgPolicy::pkgPolicy·(pkgCache·*Owner)
123 ······make·ExpressionMatches·static·to·use·it·here·easily123 ······make·ExpressionMatches·static·to·use·it·here·easily
124 ··Member·pkgProblemResolver::ResolveInternal·(bool·const·BrokenFix=false)124 ··Member·pkgProblemResolver::ResolveInternal·(bool·const·BrokenFix=false)
125 ······we·should·undo·the·complete·MarkInstall·process·here125 ······we·should·undo·the·complete·MarkInstall·process·here
126 ······use·DoUpgrade(Pkg)·instead?126 ······use·DoUpgrade(Pkg)·instead?
127 ··Member·pkgSrcRecords::Parser::BuildDepends·(std::vector<·BuildDepRec·>127 ··Member·pkgSrcRecords::Parser::BuildDepends·(std::vector<·BuildDepRec·>
Max diff block lines reached; 0/6456 bytes (0.00%) of diff not shown.
Generated by diffoscope 240