\n - Module acquire
\n - Acquire supports inserting an object into several queues at once, but it is not clear what its behavior in this case is, and no subclass of pkgAcquire::Item seems to actually use this capability.
\n+- Member MMap::Map (FileFd &Fd)
\n+- Writing to compressed fd's ?
\n+- Class pkgAcqIndex
\n+- Why does pkgAcqIndex have protected members?
\n+- Class pkgAcqMetaSig
\n+- Why protected members?
\n+- Class pkgAcquire
\n+Why so many protected values?
\n+Why all the protected data items and methods?
\n+Like everything else in the Acquire system, this has way too many protected items.
\n+- Member pkgCdrom::Add (pkgCdromStatus *log)
\n+- We ignore stat() errors here as we usually have only one of those in use
\n+- Member pkgDPkgPM::Go (APT::Progress::PackageManager *progress) APT_OVERRIDE
\n+- workaround for dpkg bug, see our ./test-bug-740843-versioned-up-down-breaks test
\n - Member CacheSetHelper::PackageFromString (PackageContainerInterface *const pci, pkgCacheFile &Cache, std::string const &pattern)
\n - hm, hm, regexp/fnmatch incompatible?
\n - Member CommandLine::GetCommand (Dispatch const *const Map, unsigned int const argc, char const *const *const argv) APT_PURE
\n - How like is it that an option parameter will be also a valid Match ?
\n - Member debReleaseIndex::Load (std::string const &Filename, std::string *const ErrorText) APT_OVERRIDE
\n - find better tag name
\n - Member edspListParser::ParseStatus (pkgCache::PkgIterator &Pkg, pkgCache::VerIterator &Ver) APT_OVERRIDE
\n - Using an overriding pin is wrong.
\n-- Member MMap::Map (FileFd &Fd)
\n-- Writing to compressed fd's ?
\n - Member PackageManagerFancy::GetTerminalSize ()
\n - get from \"child_pty\" instead?
\n - Member PackageManagerProgressDeb822Fd::StartDpkg () APT_OVERRIDE
\n - use SetCloseExec here once it taught about throwing
\n - Member PackageManagerProgressFd::StartDpkg () APT_OVERRIDE
\n - use SetCloseExec here once it taught about throwing
\n - Member pkgAcqDiffIndex::ParseDiffIndex (std::string const &IndexDiffFile)
\n - all of pdiff supports only .gz compressed patches
\n - Member pkgAcqDiffIndex::pkgAcqDiffIndex (pkgAcquire *const Owner, pkgAcqMetaClearSig *const TransactionManager, IndexTarget const &Target) APT_NONNULL(2
\n - Magic number as an upper bound on pdiffs we will reasonably acquire
\n-- Class pkgAcqIndex
\n-- Why does pkgAcqIndex have protected members?
\n - Member pkgAcqIndexDiffs::available_patches
\n - These are indexed by sha1sum; why not use some sort of dictionary instead of relying on ordering and stripping them off the front?
\n-- Class pkgAcqMetaSig
\n-- Why protected members?
\n - Member pkgAcqMetaSig::Failed (std::string const &Message, pkgAcquire::MethodConfig const *const Cnf) APT_OVERRIDE
\n - this is used often (e.g. in pkgAcqIndexTrans) so refactor
\n-- Class pkgAcquire
\n-Why all the protected data items and methods?
\n-Why so many protected values?
\n-Like everything else in the Acquire system, this has way too many protected items.
\n-- Member pkgAcquire::Access
\n - Doesn't this duplicate Config->Access?
\n - Member pkgAcquire::Bump ()
\n - Why both this and Cycle()? Are they expected to be different someday?
\n - Member pkgAcquire::Configs
\n - why a hand-managed config dictionary instead of std::map?
\n - Member pkgAcquire::InReady
\n@@ -100,18 +104,18 @@\n - Wouldn't a std::dequeue be more appropriate?
\n - Member pkgAcquire::OutReady
\n - Is this right?
\n - Member pkgAcquire::Queues
\n - why a hand-managed list of queues instead of std::list or std::set?
\n - Member pkgAcquire::RunMessages ()
\n - Several message types lack separate handlers.
\n-- Member pkgAcquire::Workers
\n-Why not just use a std::set?
\n-why a hand-managed list of workers instead of std::list or std::set?
\n-This is plural because support exists in Queue for multiple workers. However, it does not appear that there is any way to actually associate more than one worker with a queue.
\n+- Member pkgAcquire::Workers
\n+why a hand-managed list of workers instead of std::list or std::set?
\n+This is plural because support exists in Queue for multiple workers. However, it does not appear that there is any way to actually associate more than one worker with a queue.
\n+Why not just use a std::set?
\n - Class pkgAcquireStatus
\n - Why protected members?
\n - Member pkgAcquireStatus::MediaChange (std::string Media, std::string Drive)=0
\n - This is a horrible blocking monster; it should be CPSed with prejudice.
\n - Member pkgCache< Str, Itr >::DescFile::Size
\n - document pkgCache::DescFile::Size
\n@@ -123,31 +127,27 @@\n - enumerate at least the possible indexes
\n - Member pkgCache< Str, Itr >::ReleaseFile::Flags
\n - document PackageFile::Flags
\n - Member pkgCache< Str, Itr >::VerFile::Size
\n - document pkgCache::VerFile::Size
\n - Member pkgCacheGenerator::MakeStatusCache (pkgSourceList &List, OpProgress *Progress, MMap **OutMap, pkgCache **OutCache, bool AllowMem=false)
\n - deprecate the ignored AllowMem parameter
\n-- Member pkgCdrom::Add (pkgCdromStatus *log)
\n-- We ignore stat() errors here as we usually have only one of those in use
\n - Member pkgDepCache::GetRootSetFunc ()
\n - Is this the best place for this function? Perhaps the settings for mark-and-sweep should be stored in a single external class?
\n - Member pkgDepCache::Policy::IsImportantDep (DepIterator const &Dep) const
\n - this is a meant as a temporary solution until the
\n-- Member pkgDPkgPM::Go (APT::Progress::PackageManager *progress) APT_OVERRIDE
\n-- workaround for dpkg bug, see our ./test-bug-740843-versioned-up-down-breaks test
\n - Member pkgDPkgPM::OpenLog ()
\n - use a better string after freeze
\n - Member pkgDPkgPM::ProcessDpkgStatusLine (char *line)
\n-2: is \"pkgname\" here reliable with dpkg only sending us
\n-this needs a muliarch testcase
\n+this needs a muliarch testcase
\n+2: is \"pkgname\" here reliable with dpkg only sending us
\n - Member pkgPackageManager::EarlyRemove (PkgIterator Pkg, DepIterator const *const Dep) APT_MUSTCHECK
\n-Unify messaging with Protected below.
\n-Message should talk about Protected, not Essential, and unified.
\n+Message should talk about Protected, not Essential, and unified.
\n+Unify messaging with Protected below.
\n - Member pkgPolicy::pkgPolicy (pkgCache *Owner)
\n - make ExpressionMatches static to use it here easily
\n - Member pkgProblemResolver::ResolveInternal (bool const BrokenFix=false)
\n we should undo the complete MarkInstall process here
\n use DoUpgrade(Pkg) instead?
\n