Diff of the two buildlogs: -- --- b1/build.log 2023-04-22 05:55:53.293578457 +0000 +++ b2/build.log 2023-04-22 05:56:29.483973701 +0000 @@ -1,6 +1,6 @@ I: pbuilder: network access will be disabled during build -I: Current time: Fri Apr 21 17:55:14 -12 2023 -I: pbuilder-time-stamp: 1682142914 +I: Current time: Sat May 25 02:18:55 +14 2024 +I: pbuilder-time-stamp: 1716553135 I: Building the build Environment I: extracting base tarball [/var/cache/pbuilder/bookworm-reproducible-base.tgz] I: copying local configuration @@ -16,7 +16,7 @@ I: copying [./recoverdm_0.20.orig.tar.gz] I: copying [./recoverdm_0.20-8.debian.tar.xz] I: Extracting source -gpgv: Signature made Mon Sep 20 12:50:35 2021 -12 +gpgv: Signature made Tue Sep 21 14:50:35 2021 +14 gpgv: using RSA key 357DCB0EEC95A01AEBA1F0D2DE63B9C704EBE9EF gpgv: Can't check signature: No public key dpkg-source: warning: cannot verify inline signature for ./recoverdm_0.20-8.dsc: no acceptable signature found @@ -30,52 +30,84 @@ dpkg-source: info: applying 40_dev-c.patch I: Not using root during the build. I: Installing the build-deps -I: user script /srv/workspace/pbuilder/9517/tmp/hooks/D02_print_environment starting +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/D01_modify_environment starting +debug: Running on codethink15-arm64. +I: Changing host+domainname to test build reproducibility +I: Adding a custom variable just for the fun of it... +I: Changing /bin/sh to bash +'/bin/sh' -> '/bin/bash' +lrwxrwxrwx 1 root root 9 May 25 02:19 /bin/sh -> /bin/bash +I: Setting pbuilder2's login shell to /bin/bash +I: Setting pbuilder2's GECOS to second user,second room,second work-phone,second home-phone,second other +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/D01_modify_environment finished +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/D02_print_environment starting I: set - BUILDDIR='/build' - BUILDUSERGECOS='first user,first room,first work-phone,first home-phone,first other' - BUILDUSERNAME='pbuilder1' - BUILD_ARCH='arm64' - DEBIAN_FRONTEND='noninteractive' + BASH=/bin/sh + BASHOPTS=checkwinsize:cmdhist:complete_fullquote:extquote:force_fignore:globasciiranges:globskipdots:hostcomplete:interactive_comments:patsub_replacement:progcomp:promptvars:sourcepath + BASH_ALIASES=() + BASH_ARGC=() + BASH_ARGV=() + BASH_CMDS=() + BASH_LINENO=([0]="12" [1]="0") + BASH_LOADABLES_PATH=/usr/local/lib/bash:/usr/lib/bash:/opt/local/lib/bash:/usr/pkg/lib/bash:/opt/pkg/lib/bash:. + BASH_SOURCE=([0]="/tmp/hooks/D02_print_environment" [1]="/tmp/hooks/D02_print_environment") + BASH_VERSINFO=([0]="5" [1]="2" [2]="15" [3]="1" [4]="release" [5]="aarch64-unknown-linux-gnu") + BASH_VERSION='5.2.15(1)-release' + BUILDDIR=/build + BUILDUSERGECOS='second user,second room,second work-phone,second home-phone,second other' + BUILDUSERNAME=pbuilder2 + BUILD_ARCH=arm64 + DEBIAN_FRONTEND=noninteractive DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=8' - DISTRIBUTION='bookworm' - HOME='/var/lib/jenkins' - HOST_ARCH='arm64' + DIRSTACK=() + DISTRIBUTION=bookworm + EUID=0 + FUNCNAME=([0]="Echo" [1]="main") + GROUPS=() + HOME=/var/lib/jenkins + HOSTNAME=i-capture-the-hostname + HOSTTYPE=aarch64 + HOST_ARCH=arm64 IFS=' ' - LANG='C' - LANGUAGE='en_US:en' - LC_ALL='C' - MAIL='/var/mail/root' - OPTIND='1' - PATH='/usr/sbin:/usr/bin:/sbin:/bin:/usr/games' - PBCURRENTCOMMANDLINEOPERATION='build' - PBUILDER_OPERATION='build' - PBUILDER_PKGDATADIR='/usr/share/pbuilder' - PBUILDER_PKGLIBDIR='/usr/lib/pbuilder' - PBUILDER_SYSCONFDIR='/etc' - PPID='9517' - PS1='# ' - PS2='> ' + LANG=C + LANGUAGE=nl_BE:nl + LC_ALL=C + MACHTYPE=aarch64-unknown-linux-gnu + MAIL=/var/mail/root + OPTERR=1 + OPTIND=1 + OSTYPE=linux-gnu + PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path + PBCURRENTCOMMANDLINEOPERATION=build + PBUILDER_OPERATION=build + PBUILDER_PKGDATADIR=/usr/share/pbuilder + PBUILDER_PKGLIBDIR=/usr/lib/pbuilder + PBUILDER_SYSCONFDIR=/etc + PIPESTATUS=([0]="0") + POSIXLY_CORRECT=y + PPID=13454 PS4='+ ' - PWD='/' - SHELL='/bin/bash' - SHLVL='2' - SUDO_COMMAND='/usr/bin/timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.zbsXUxXU/pbuilderrc_4hp2 --distribution bookworm --hookdir /etc/pbuilder/first-build-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/bookworm-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.zbsXUxXU/b1 --logfile b1/build.log recoverdm_0.20-8.dsc' - SUDO_GID='117' - SUDO_UID='110' - SUDO_USER='jenkins' - TERM='unknown' - TZ='/usr/share/zoneinfo/Etc/GMT+12' - USER='root' - USERNAME='root' - _='/usr/bin/systemd-run' - http_proxy='http://192.168.101.16:3128' + PWD=/ + SHELL=/bin/bash + SHELLOPTS=braceexpand:errexit:hashall:interactive-comments:posix + SHLVL=3 + SUDO_COMMAND='/usr/bin/timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice -n 11 /usr/bin/unshare --uts -- /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.zbsXUxXU/pbuilderrc_wGer --distribution bookworm --hookdir /etc/pbuilder/rebuild-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/bookworm-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.zbsXUxXU/b2 --logfile b2/build.log --extrapackages usrmerge recoverdm_0.20-8.dsc' + SUDO_GID=117 + SUDO_UID=110 + SUDO_USER=jenkins + TERM=unknown + TZ=/usr/share/zoneinfo/Etc/GMT-14 + UID=0 + USER=root + USERNAME=root + _='I: set' + http_proxy=http://192.168.101.16:3128 I: uname -a - Linux codethink12-arm64 4.15.0-209-generic #220-Ubuntu SMP Tue Mar 21 19:52:44 UTC 2023 aarch64 GNU/Linux + Linux i-capture-the-hostname 4.15.0-209-generic #220-Ubuntu SMP Tue Mar 21 19:52:44 UTC 2023 aarch64 GNU/Linux I: ls -l /bin - lrwxrwxrwx 1 root root 7 Apr 20 22:25 /bin -> usr/bin -I: user script /srv/workspace/pbuilder/9517/tmp/hooks/D02_print_environment finished + lrwxrwxrwx 1 root root 7 May 22 06:47 /bin -> usr/bin +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/D02_print_environment finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy @@ -141,7 +173,7 @@ Get: 28 http://deb.debian.org/debian bookworm/main arm64 intltool-debian all 0.35.0+20060710.6 [22.9 kB] Get: 29 http://deb.debian.org/debian bookworm/main arm64 po-debconf all 1.0.21+nmu1 [248 kB] Get: 30 http://deb.debian.org/debian bookworm/main arm64 debhelper all 13.11.4 [942 kB] -Fetched 18.3 MB in 2s (7575 kB/s) +Fetched 18.3 MB in 0s (44.0 MB/s) debconf: delaying package configuration, since apt-utils is not installed Selecting previously unselected package sensible-utils. (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading database ... 70% (Reading database ... 75% (Reading database ... 80% (Reading database ... 85% (Reading database ... 90% (Reading database ... 95% (Reading database ... 100% (Reading database ... 19616 files and directories currently installed.) @@ -275,8 +307,17 @@ Writing extended state information... Building tag database... -> Finished parsing the build-deps +Reading package lists... +Building dependency tree... +Reading state information... +usrmerge is already the newest version (35). +0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. I: Building the package -I: Running cd /build/recoverdm-0.20/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-genchanges -S > ../recoverdm_0.20-8_source.changes +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/A99_set_merged_usr starting +Re-configuring usrmerge... +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/A99_set_merged_usr finished +hostname: Temporary failure in name resolution +I: Running cd /build/recoverdm-0.20/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-genchanges -S > ../recoverdm_0.20-8_source.changes dpkg-buildpackage: info: source package recoverdm dpkg-buildpackage: info: source version 0.20-8 dpkg-buildpackage: info: source distribution unstable @@ -305,10 +346,66 @@ cc -g -O2 -ffile-prefix-map=/build/recoverdm-0.20=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wshadow -Wconversion -Wwrite-strings -Winline -O2 -DVERSION=\"0.20\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o utils.o utils.c cc -g -O2 -ffile-prefix-map=/build/recoverdm-0.20=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wshadow -Wconversion -Wwrite-strings -Winline -O2 -DVERSION=\"0.20\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o error.o error.c cc -g -O2 -ffile-prefix-map=/build/recoverdm-0.20=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wshadow -Wconversion -Wwrite-strings -Winline -O2 -DVERSION=\"0.20\" -Wdate-time -D_FORTIFY_SOURCE=2 -c -o mergebad.o mergebad.c +utils.c: In function 'mymalloc': +utils.c:21:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 21 | error_exit("failed to allocate %d bytes for %s\n", size, what); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +In file included from utils.c:15: +error.h:1:23: note: expected 'char *' but argument is of type 'const char *' + 1 | void error_exit(char *format, ...); + | ~~~~~~^~~~~~ +utils.c: In function 'myrealloc': +utils.c:30:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 30 | error_exit("failed to reallocate to %d bytes for %s\n", newsize, what); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +error.h:1:23: note: expected 'char *' but argument is of type 'const char *' + 1 | void error_exit(char *format, ...); + | ~~~~~~^~~~~~ +utils.c: In function 'get_filesize': +utils.c:40:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 40 | error_exit("Failed to retrieve length of file %s: %s (%d)\n", filename, strerror(errno), errno); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +error.h:1:23: note: expected 'char *' but argument is of type 'const char *' + 1 | void error_exit(char *format, ...); + | ~~~~~~^~~~~~ +In file included from utils.c:13: +utils.c: In function 'copy_block': +gen.h:1:25: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'off64_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] + 1 | #define min(x, y) ((x)<(y)?(x):(y)) + | ^ +utils.c:51:38: note: in expansion of macro 'min' + 51 | size_t sector_size = min(block_size, 512); + | ^~~ +utils.c:56:58: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] + 56 | fprintf(stderr, "Failed to read %d bytes from inputfile: %s (%d)\n", sector_size, strerror(errno), errno); + | ~^ ~~~~~~~~~~~ + | | | + | int size_t {aka long unsigned int} + | %ld +utils.c:68:28: warning: conversion to 'long unsigned int' from 'off64_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] + 68 | block_size -= sector_size; + | ^~ +utils.c:68:31: warning: conversion to 'off64_t' {aka 'long int'} from 'long unsigned int' may change the sign of the result [-Wsign-conversion] + 68 | block_size -= sector_size; + | ^~~~~~~~~~~ +utils.c: In function 'myseek': +utils.c:78:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 78 | error_exit("Failed to seek in file to offset %lld: %s (%d)\n", offset, strerror(errno), errno); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +error.h:1:23: note: expected 'char *' but argument is of type 'const char *' + 1 | void error_exit(char *format, ...); + | ~~~~~~^~~~~~ +mergebad.c: In function 'find_image_without_badblock': io.c: In function 'READ': io.c:30:52: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 30 | error_exit("unexpected error while reading: %s (%d)\n", strerror(errno), errno); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +mergebad.c:45:64: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'off64_t' {aka 'long int'} [-Wformat=] + 45 | printf("> find_image_without_badblock(%p %d %lld)\n", imgs, n_imgs, offset); + | ~~~^ ~~~~~~ + | | | + | long long int off64_t {aka long int} + | %ld In file included from io.c:12: error.h:1:23: note: expected 'char *' but argument is of type 'const char *' 1 | void error_exit(char *format, ...); @@ -320,29 +417,6 @@ io.c:75:29: warning: conversion to 'long unsigned int' from 'ssize_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] 75 | len -= rc; | ^~ -io.c: In function 'phantom_write': -io.c:126:35: warning: conversion from 'ssize_t' {aka 'long int'} to 'int' may change value [-Wconversion] - 126 | if ((rc = WRITE(fd, in, move_a_little)) <= 0) - | ^~~~~ -io.c:132:39: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] - 132 | move_a_little -= rc; - | ^~ -io.c:163:43: warning: conversion from 'ssize_t' {aka 'long int'} to 'int' may change value [-Wconversion] - 163 | if ((rc = WRITE(fd, in, 512)) <= 0) - | ^~~~~ -io.c:172:35: warning: conversion from 'ssize_t' {aka 'long int'} to 'int' may change value [-Wconversion] - 172 | if ((rc = WRITE(fd, in, nbytes)) <= 0) - | ^~~~~ -io.c:181:24: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] - 181 | nbytes -= rc; - | ^~ -mergebad.c: In function 'find_image_without_badblock': -mergebad.c:45:64: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'off64_t' {aka 'long int'} [-Wformat=] - 45 | printf("> find_image_without_badblock(%p %d %lld)\n", imgs, n_imgs, offset); - | ~~~^ ~~~~~~ - | | | - | long long int off64_t {aka long int} - | %ld mergebad.c:59:53: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'off64_t' {aka 'long int'} [-Wformat=] 59 | printf("= %d/%d, %lld - %lld\n", img_index, badblock_index, cur_offset, cur_bb_end); | ~~~^ ~~~~~~~~~~ @@ -356,24 +430,57 @@ | long long int off64_t {aka long int} | %ld mergebad.c: In function 'find_smallest_current_badblock': +recoverdm.c: In function 'lba_to_msf': +recoverdm.c:55:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] + 55 | *minute = (lba + 150) / (60 * 75); + | ^ mergebad.c:103:67: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'off64_t' {aka 'long int'} [-Wformat=] 103 | printf("> find_smallest_current_badblock(%p %d %lld %p %p)\n", imgs, n_imgs, offset, selected_image, selected_badblock); | ~~~^ ~~~~~~ | | | | long long int off64_t {aka long int} | %ld +recoverdm.c:57:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] + 57 | *second = (lba + 150) / 75; + | ^ +io.c: In function 'phantom_write': +recoverdm.c:59:26: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] + 59 | *frame = (lba + 150); + | ^ +io.c:126:35: warning: conversion from 'ssize_t' {aka 'long int'} to 'int' may change value [-Wconversion] + 126 | if ((rc = WRITE(fd, in, move_a_little)) <= 0) + | ^~~~~ +recoverdm.c:63:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] + 63 | *minute = (lba + 450150) / (60 * 75); + | ^ +io.c:132:39: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] + 132 | move_a_little -= rc; + | ^~ +recoverdm.c:65:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] + 65 | *second = (lba + 450150) / 75; + | ^ mergebad.c:118:53: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'off64_t' {aka 'long int'} [-Wformat=] 118 | printf("= %d/%d, %lld - %lld\n", img_index, badblock_index, cur_offset, cur_bb_end); | ~~~^ ~~~~~~~~~~ | | | | long long int off64_t {aka long int} | %ld +recoverdm.c:67:26: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] + 67 | *frame = (lba + 450150); + | ^ mergebad.c:118:60: warning: format '%lld' expects argument of type 'long long int', but argument 5 has type 'off64_t' {aka 'long int'} [-Wformat=] 118 | printf("= %d/%d, %lld - %lld\n", img_index, badblock_index, cur_offset, cur_bb_end); | ~~~^ ~~~~~~~~~~ | | | | long long int off64_t {aka long int} | %ld +recoverdm.c: In function 'create_sector': +recoverdm.c:75:57: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 75 | char *sector_out = (char *)mymalloc(block_size, "sector"); + | ^~~~~~~~ +io.c:163:43: warning: conversion from 'ssize_t' {aka 'long int'} to 'int' may change value [-Wconversion] + 163 | if ((rc = WRITE(fd, in, 512)) <= 0) + | ^~~~~ mergebad.c:130:68: warning: format '%lld' expects argument of type 'long long int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] 130 | printf("= # bytes left: %lld\n", block_size_left); | ~~~^ ~~~~~~~~~~~~~~~ @@ -381,13 +488,36 @@ | | off64_t {aka long int} | long long int | %ld +In file included from recoverdm.c:13: +utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' + 1 | void * mymalloc(size_t size, char *what); + | ~~~~~~^~~~ +io.c:172:35: warning: conversion from 'ssize_t' {aka 'long int'} to 'int' may change value [-Wconversion] + 172 | if ((rc = WRITE(fd, in, nbytes)) <= 0) + | ^~~~~ mergebad.c:148:69: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'off64_t' {aka 'long int'} [-Wformat=] 148 | printf("> find_smallest_current_badblock: %d %d (%lld)\n", *selected_image, *selected_badblock, smallest_block_size); | ~~~^ ~~~~~~~~~~~~~~~~~~~ | | | | long long int off64_t {aka long int} | %ld +io.c:181:24: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] + 181 | nbytes -= rc; + | ^~ +recoverdm.c:107:53: warning: conversion from 'int' to 'short int' may change value [-Wconversion] + 107 | chosen_byte_count = count[loop2]; + | ^~~~~ +recoverdm.c:108:47: warning: conversion from 'int' to 'short int' may change value [-Wconversion] + 108 | chosen_byte = loop2; + | ^~~~~ +recoverdm.c:126:44: warning: conversion from 'short int' to 'char' may change value [-Wconversion] + 126 | sector_out[loop] = chosen_byte; + | ^~~~~~~~~~~ +recoverdm.c: In function 'get_raw_cd': mergebad.c: In function 'read_mapfile': +recoverdm.c:169:71: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result [-Wsign-conversion] + 169 | char **sector_list = (char **)mymalloc(sizeof(char *) * n_raw_retries, "sectorlist"); + | ^ mergebad.c:189:32: warning: format '%lld' expects argument of type 'long long int *', but argument 3 has type 'off64_t *' {aka 'long int *'} [-Wformat=] 189 | fscanf(fh, "%lld %d", &offset, &block_size); | ~~~^ ~~~~~~~ @@ -395,16 +525,36 @@ | | off64_t * {aka long int *} | long long int * | %ld +recoverdm.c:169:88: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 169 | char **sector_list = (char **)mymalloc(sizeof(char *) * n_raw_retries, "sectorlist"); + | ^~~~~~~~~~~~ +utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' + 1 | void * mymalloc(size_t size, char *what); + | ~~~~~~^~~~ mergebad.c:191:67: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result [-Wsign-conversion] 191 | bbs = (badblock *)myrealloc(bbs, sizeof(badblock) * (n_bb + 1), "badblocks list"); | ^ +recoverdm.c:174:74: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 174 | sector_list[loop] = (char *)mymalloc(block_size, "sector"); + | ^~~~~~~~ mergebad.c:191:81: warning: passing argument 3 of 'myrealloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 191 | bbs = (badblock *)myrealloc(bbs, sizeof(badblock) * (n_bb + 1), "badblocks list"); | ^~~~~~~~~~~~~~~~ +utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' + 1 | void * mymalloc(size_t size, char *what); + | ~~~~~~^~~~ In file included from mergebad.c:14: utils.h:2:52: note: expected 'char *' but argument is of type 'const char *' 2 | void * myrealloc(void *oldp, size_t newsize, char *what); | ~~~~~~^~~~ +recoverdm.c:184:43: warning: passing argument 1 of 'create_sector' from incompatible pointer type [-Wincompatible-pointer-types] + 184 | if (create_sector(sector_list, n_raw_retries, block_size, &dummy) == -1) + | ^~~~~~~~~~~ + | | + | char ** +recoverdm.c:71:35: note: expected 'unsigned char **' but argument is of type 'char **' + 71 | int create_sector(unsigned char **sectors, int n_sectors, size_t block_size, char **psector_out) + | ~~~~~~~~~~~~~~~~^~~~~~~ mergebad.c:196:40: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'off64_t' {aka 'long int'} [-Wformat=] 196 | printf("%d] %lld %lld\n", n_bb, offset, block_size); | ~~~^ ~~~~~~ @@ -417,10 +567,17 @@ | | | | long long int int | %d +recoverdm.c: In function 'main': +recoverdm.c:215:23: warning: unsigned conversion from 'int' to 'char' changes value from '-1' to '255' [-Wsign-conversion] + 215 | char dev_type=-1, cd_speed=DEFAULT_CD_SPEED; + | ^ mergebad.c: In function 'select_most_occuring_byte': mergebad.c:228:41: warning: conversion from 'int' to 'char' may change value [-Wconversion] 228 | selected_byte = loop; | ^~~~ +recoverdm.c:235:36: warning: conversion from 'int' to 'char' may change value [-Wconversion] + 235 | dev_type = atoi(optarg); + | ^~~~ mergebad.c:235:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 235 | error_exit("Internal error: no byte found!"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -428,6 +585,15 @@ error.h:1:23: note: expected 'char *' but argument is of type 'const char *' 1 | void error_exit(char *format, ...); | ~~~~~~^~~~~~ +recoverdm.c:256:37: warning: conversion from 'int' to 'char' may change value [-Wconversion] + 256 | n_retries = atoi(optarg); + | ^~~~ +recoverdm.c:262:36: warning: conversion from 'int' to 'char' may change value [-Wconversion] + 262 | cd_speed = atoi(optarg); + | ^~~~ +recoverdm.c:265:44: warning: conversion from 'int' to 'char' may change value [-Wconversion] + 265 | n_raw_cd_retries = atoi(optarg); + | ^~~~ mergebad.c: In function 'main': mergebad.c:272:62: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result [-Wsign-conversion] 272 | imgs = myrealloc(imgs, sizeof(image) * (n_imgs + 1), "image structure"); @@ -438,24 +604,59 @@ utils.h:2:52: note: expected 'char *' but argument is of type 'const char *' 2 | void * myrealloc(void *oldp, size_t newsize, char *what); | ~~~~~~^~~~ +recoverdm.c:307:47: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 307 | buffer = (char *)mymalloc(block_size, "sectorbuffer"); + | ^~~~~~~~~~~~~~ +utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' + 1 | void * mymalloc(size_t size, char *what); + | ~~~~~~^~~~ +recoverdm.c:308:48: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] + 308 | buffer2 = (char *)mymalloc(block_size, "sectorbuffer for retries"); + | ^~~~~~~~~~~~~~~~~~~~~~~~~~ +utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' + 1 | void * mymalloc(size_t size, char *what); + | ~~~~~~^~~~ mergebad.c:293:61: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'off64_t' {aka 'long int'} [-Wformat=] 293 | printf("Adding image: %s/%lld number of badblocks: %d\n", imgs[n_imgs].filename, imgs[n_imgs].size, imgs[n_imgs].bb_list_size); | ~~~^ ~~~~~~~~~~~~~~~~~ | | | | long long int off64_t {aka long int} | %ld +recoverdm.c:361:28: warning: format '%lld' expects argument of type 'long long int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] + 361 | printf("%lld\r", curpos); + | ~~~^ ~~~~~~ + | | | + | | off64_t {aka long int} + | long long int + | %ld mergebad.c:321:57: warning: format '%d' expects argument of type 'int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] 321 | printf("Length set to: %d\n", length); | ~^ ~~~~~~ | | | | int off64_t {aka long int} | %ld +recoverdm.c:388:45: warning: format '%lld' expects argument of type 'long long int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] + 388 | printf("error at %lld bytes, retrying: %d\n", curpos, n); + | ~~~^ ~~~~~~ + | | | + | long long int off64_t {aka long int} + | %ld +recoverdm.c:445:91: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] + 445 | fprintf(dsecfile, "%lld %ld\n", curpos, block_size*skip_value); + | ^ mergebad.c:363:74: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'off64_t' {aka 'long int'} [-Wformat=] 363 | printf("No filelength given, using length of file %s: %lld\n", imgs[0].filename, (length = get_filesize(imgs[0].filename))); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | long long int off64_t {aka long int} | %ld +recoverdm.c:445:63: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'off64_t' {aka 'long int'} [-Wformat=] + 445 | fprintf(dsecfile, "%lld %ld\n", curpos, block_size*skip_value); + | ~~~^ ~~~~~~ + | | | + | | off64_t {aka long int} + | long long int + | %ld mergebad.c:371:52: warning: format '%lld' expects argument of type 'long long int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] 371 | printf("Current offset: %lld\n", offset); | ~~~^ ~~~~~~ @@ -463,6 +664,9 @@ | | off64_t {aka long int} | long long int | %ld +recoverdm.c:440:38: warning: variable 'ok' set but not used [-Wunused-but-set-variable] + 440 | char ok = 1; + | ^~ mergebad.c:394:54: warning: format '%lld' expects argument of type 'long long int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] 394 | printf("Will copy %lld bytes from file %s\n", n_bytes_to_copy, imgs[img_index].filename); | ~~~^ ~~~~~~~~~~~~~~~ @@ -538,171 +742,8 @@ mergebad.c:189:17: warning: ignoring return value of 'fscanf' declared with attribute 'warn_unused_result' [-Wunused-result] 189 | fscanf(fh, "%lld %d", &offset, &block_size); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -recoverdm.c: In function 'lba_to_msf': -recoverdm.c:55:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] - 55 | *minute = (lba + 150) / (60 * 75); - | ^ -recoverdm.c:57:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] - 57 | *second = (lba + 150) / 75; - | ^ -recoverdm.c:59:26: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] - 59 | *frame = (lba + 150); - | ^ -recoverdm.c:63:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] - 63 | *minute = (lba + 450150) / (60 * 75); - | ^ -recoverdm.c:65:27: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] - 65 | *second = (lba + 450150) / 75; - | ^ -recoverdm.c:67:26: warning: conversion from 'off64_t' {aka 'long int'} to 'unsigned char' may change value [-Wconversion] - 67 | *frame = (lba + 450150); - | ^ -recoverdm.c: In function 'create_sector': -recoverdm.c:75:57: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 75 | char *sector_out = (char *)mymalloc(block_size, "sector"); - | ^~~~~~~~ -In file included from recoverdm.c:13: -utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' - 1 | void * mymalloc(size_t size, char *what); - | ~~~~~~^~~~ -recoverdm.c:107:53: warning: conversion from 'int' to 'short int' may change value [-Wconversion] - 107 | chosen_byte_count = count[loop2]; - | ^~~~~ -recoverdm.c:108:47: warning: conversion from 'int' to 'short int' may change value [-Wconversion] - 108 | chosen_byte = loop2; - | ^~~~~ -recoverdm.c:126:44: warning: conversion from 'short int' to 'char' may change value [-Wconversion] - 126 | sector_out[loop] = chosen_byte; - | ^~~~~~~~~~~ -utils.c: In function 'mymalloc': -utils.c:21:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 21 | error_exit("failed to allocate %d bytes for %s\n", size, what); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -In file included from utils.c:15: -error.h:1:23: note: expected 'char *' but argument is of type 'const char *' - 1 | void error_exit(char *format, ...); - | ~~~~~~^~~~~~ -utils.c: In function 'myrealloc': -utils.c:30:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 30 | error_exit("failed to reallocate to %d bytes for %s\n", newsize, what); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -error.h:1:23: note: expected 'char *' but argument is of type 'const char *' - 1 | void error_exit(char *format, ...); - | ~~~~~~^~~~~~ -utils.c: In function 'get_filesize': -utils.c:40:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 40 | error_exit("Failed to retrieve length of file %s: %s (%d)\n", filename, strerror(errno), errno); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -error.h:1:23: note: expected 'char *' but argument is of type 'const char *' - 1 | void error_exit(char *format, ...); - | ~~~~~~^~~~~~ -In file included from utils.c:13: -utils.c: In function 'copy_block': -gen.h:1:25: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'off64_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] - 1 | #define min(x, y) ((x)<(y)?(x):(y)) - | ^ -utils.c:51:38: note: in expansion of macro 'min' - 51 | size_t sector_size = min(block_size, 512); - | ^~~ -utils.c:56:58: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] - 56 | fprintf(stderr, "Failed to read %d bytes from inputfile: %s (%d)\n", sector_size, strerror(errno), errno); - | ~^ ~~~~~~~~~~~ - | | | - | int size_t {aka long unsigned int} - | %ld -utils.c:68:28: warning: conversion to 'long unsigned int' from 'off64_t' {aka 'long int'} may change the sign of the result [-Wsign-conversion] - 68 | block_size -= sector_size; - | ^~ -utils.c:68:31: warning: conversion to 'off64_t' {aka 'long int'} from 'long unsigned int' may change the sign of the result [-Wsign-conversion] - 68 | block_size -= sector_size; - | ^~~~~~~~~~~ -utils.c: In function 'myseek': -utils.c:78:28: warning: passing argument 1 of 'error_exit' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 78 | error_exit("Failed to seek in file to offset %lld: %s (%d)\n", offset, strerror(errno), errno); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -error.h:1:23: note: expected 'char *' but argument is of type 'const char *' - 1 | void error_exit(char *format, ...); - | ~~~~~~^~~~~~ -recoverdm.c: In function 'get_raw_cd': -recoverdm.c:169:71: warning: conversion to 'long unsigned int' from 'int' may change the sign of the result [-Wsign-conversion] - 169 | char **sector_list = (char **)mymalloc(sizeof(char *) * n_raw_retries, "sectorlist"); - | ^ -recoverdm.c:169:88: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 169 | char **sector_list = (char **)mymalloc(sizeof(char *) * n_raw_retries, "sectorlist"); - | ^~~~~~~~~~~~ -utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' - 1 | void * mymalloc(size_t size, char *what); - | ~~~~~~^~~~ -recoverdm.c:174:74: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 174 | sector_list[loop] = (char *)mymalloc(block_size, "sector"); - | ^~~~~~~~ -utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' - 1 | void * mymalloc(size_t size, char *what); - | ~~~~~~^~~~ -recoverdm.c:184:43: warning: passing argument 1 of 'create_sector' from incompatible pointer type [-Wincompatible-pointer-types] - 184 | if (create_sector(sector_list, n_raw_retries, block_size, &dummy) == -1) - | ^~~~~~~~~~~ - | | - | char ** -recoverdm.c:71:35: note: expected 'unsigned char **' but argument is of type 'char **' - 71 | int create_sector(unsigned char **sectors, int n_sectors, size_t block_size, char **psector_out) - | ~~~~~~~~~~~~~~~~^~~~~~~ -recoverdm.c: In function 'main': -recoverdm.c:215:23: warning: unsigned conversion from 'int' to 'char' changes value from '-1' to '255' [-Wsign-conversion] - 215 | char dev_type=-1, cd_speed=DEFAULT_CD_SPEED; - | ^ -recoverdm.c:235:36: warning: conversion from 'int' to 'char' may change value [-Wconversion] - 235 | dev_type = atoi(optarg); - | ^~~~ -recoverdm.c:256:37: warning: conversion from 'int' to 'char' may change value [-Wconversion] - 256 | n_retries = atoi(optarg); - | ^~~~ -recoverdm.c:262:36: warning: conversion from 'int' to 'char' may change value [-Wconversion] - 262 | cd_speed = atoi(optarg); - | ^~~~ -recoverdm.c:265:44: warning: conversion from 'int' to 'char' may change value [-Wconversion] - 265 | n_raw_cd_retries = atoi(optarg); - | ^~~~ -recoverdm.c:307:47: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 307 | buffer = (char *)mymalloc(block_size, "sectorbuffer"); - | ^~~~~~~~~~~~~~ -utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' - 1 | void * mymalloc(size_t size, char *what); - | ~~~~~~^~~~ -recoverdm.c:308:48: warning: passing argument 2 of 'mymalloc' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] - 308 | buffer2 = (char *)mymalloc(block_size, "sectorbuffer for retries"); - | ^~~~~~~~~~~~~~~~~~~~~~~~~~ -utils.h:1:36: note: expected 'char *' but argument is of type 'const char *' - 1 | void * mymalloc(size_t size, char *what); - | ~~~~~~^~~~ -recoverdm.c:361:28: warning: format '%lld' expects argument of type 'long long int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] - 361 | printf("%lld\r", curpos); - | ~~~^ ~~~~~~ - | | | - | | off64_t {aka long int} - | long long int - | %ld -recoverdm.c:388:45: warning: format '%lld' expects argument of type 'long long int', but argument 2 has type 'off64_t' {aka 'long int'} [-Wformat=] - 388 | printf("error at %lld bytes, retrying: %d\n", curpos, n); - | ~~~^ ~~~~~~ - | | | - | long long int off64_t {aka long int} - | %ld -recoverdm.c:445:91: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] - 445 | fprintf(dsecfile, "%lld %ld\n", curpos, block_size*skip_value); - | ^ -recoverdm.c:445:63: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'off64_t' {aka 'long int'} [-Wformat=] - 445 | fprintf(dsecfile, "%lld %ld\n", curpos, block_size*skip_value); - | ~~~^ ~~~~~~ - | | | - | | off64_t {aka long int} - | long long int - | %ld -recoverdm.c:440:38: warning: variable 'ok' set but not used [-Wunused-but-set-variable] - 440 | char ok = 1; - | ^~ -cc -Wall -W mergebad.o io.o utils.o error.o -Wl,-z,relro -Wl,-z,now -o mergebad cc -Wall -W recoverdm.o dev.o io.o utils.o error.o -Wl,-z,relro -Wl,-z,now -o recoverdm +cc -Wall -W mergebad.o io.o utils.o error.o -Wl,-z,relro -Wl,-z,now -o mergebad make[1]: Leaving directory '/build/recoverdm-0.20' dh_auto_test create-stamp debian/debhelper-build-stamp @@ -743,12 +784,14 @@ dpkg-buildpackage: info: binary-only upload (no source included) dpkg-genchanges: info: not including original source code in upload I: copying local configuration +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/B01_cleanup starting +I: user script /srv/workspace/pbuilder/13454/tmp/hooks/B01_cleanup finished I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env -I: removing directory /srv/workspace/pbuilder/9517 and its subdirectories -I: Current time: Fri Apr 21 17:55:52 -12 2023 -I: pbuilder-time-stamp: 1682142952 +I: removing directory /srv/workspace/pbuilder/13454 and its subdirectories +I: Current time: Sat May 25 02:19:27 +14 2024 +I: pbuilder-time-stamp: 1716553167