Diff of the two buildlogs: -- --- b1/build.log 2025-08-29 06:59:48.011516557 +0000 +++ b2/build.log 2025-08-29 07:00:41.571579933 +0000 @@ -1,6 +1,6 @@ I: pbuilder: network access will be disabled during build -I: Current time: Thu Aug 28 18:58:40 -12 2025 -I: pbuilder-time-stamp: 1756450720 +I: Current time: Fri Oct 2 03:22:48 +14 2026 +I: pbuilder-time-stamp: 1790860968 I: Building the build Environment I: extracting base tarball [/var/cache/pbuilder/forky-reproducible-base.tgz] I: copying local configuration @@ -22,53 +22,85 @@ dpkg-source: info: unpacking ksmbd-tools_3.5.3-1.debian.tar.xz I: Not using root during the build. I: Installing the build-deps -I: user script /srv/workspace/pbuilder/3848896/tmp/hooks/D02_print_environment starting +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/D01_modify_environment starting +debug: Running on ionos5-amd64. +I: Changing host+domainname to test build reproducibility +I: Adding a custom variable just for the fun of it... +I: Changing /bin/sh to bash +'/bin/sh' -> '/bin/bash' +lrwxrwxrwx 1 root root 9 Oct 1 13:22 /bin/sh -> /bin/bash +I: Setting pbuilder2's login shell to /bin/bash +I: Setting pbuilder2's GECOS to second user,second room,second work-phone,second home-phone,second other +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/D01_modify_environment finished +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/D02_print_environment starting I: set - BUILDDIR='/build/reproducible-path' - BUILDUSERGECOS='first user,first room,first work-phone,first home-phone,first other' - BUILDUSERNAME='pbuilder1' - BUILD_ARCH='amd64' - DEBIAN_FRONTEND='noninteractive' - DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=40 ' - DISTRIBUTION='forky' - HOME='/root' - HOST_ARCH='amd64' + BASH=/bin/sh + BASHOPTS=checkwinsize:cmdhist:complete_fullquote:extquote:force_fignore:globasciiranges:globskipdots:hostcomplete:interactive_comments:patsub_replacement:progcomp:promptvars:sourcepath + BASH_ALIASES=() + BASH_ARGC=() + BASH_ARGV=() + BASH_CMDS=() + BASH_LINENO=([0]="12" [1]="0") + BASH_LOADABLES_PATH=/usr/local/lib/bash:/usr/lib/bash:/opt/local/lib/bash:/usr/pkg/lib/bash:/opt/pkg/lib/bash:. + BASH_SOURCE=([0]="/tmp/hooks/D02_print_environment" [1]="/tmp/hooks/D02_print_environment") + BASH_VERSINFO=([0]="5" [1]="2" [2]="37" [3]="1" [4]="release" [5]="x86_64-pc-linux-gnu") + BASH_VERSION='5.2.37(1)-release' + BUILDDIR=/build/reproducible-path + BUILDUSERGECOS='second user,second room,second work-phone,second home-phone,second other' + BUILDUSERNAME=pbuilder2 + BUILD_ARCH=amd64 + DEBIAN_FRONTEND=noninteractive + DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=42 ' + DIRSTACK=() + DISTRIBUTION=forky + EUID=0 + FUNCNAME=([0]="Echo" [1]="main") + GROUPS=() + HOME=/root + HOSTNAME=i-capture-the-hostname + HOSTTYPE=x86_64 + HOST_ARCH=amd64 IFS=' ' - INVOCATION_ID='8fe5dd58d84a452d8c265f88956280ad' - LANG='C' - LANGUAGE='en_US:en' - LC_ALL='C' - MAIL='/var/mail/root' - OPTIND='1' - PATH='/usr/sbin:/usr/bin:/sbin:/bin:/usr/games' - PBCURRENTCOMMANDLINEOPERATION='build' - PBUILDER_OPERATION='build' - PBUILDER_PKGDATADIR='/usr/share/pbuilder' - PBUILDER_PKGLIBDIR='/usr/lib/pbuilder' - PBUILDER_SYSCONFDIR='/etc' - PPID='3848896' - PS1='# ' - PS2='> ' + INVOCATION_ID=50917aca757948ff95dd16881bf0ff6a + LANG=C + LANGUAGE=et_EE:et + LC_ALL=C + MACHTYPE=x86_64-pc-linux-gnu + MAIL=/var/mail/root + OPTERR=1 + OPTIND=1 + OSTYPE=linux-gnu + PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path + PBCURRENTCOMMANDLINEOPERATION=build + PBUILDER_OPERATION=build + PBUILDER_PKGDATADIR=/usr/share/pbuilder + PBUILDER_PKGLIBDIR=/usr/lib/pbuilder + PBUILDER_SYSCONFDIR=/etc + PIPESTATUS=([0]="0") + POSIXLY_CORRECT=y + PPID=2160172 PS4='+ ' - PWD='/' - SHELL='/bin/bash' - SHLVL='2' - SUDO_COMMAND='/usr/bin/timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.C6876yoN/pbuilderrc_ryBW --distribution forky --hookdir /etc/pbuilder/first-build-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/forky-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.C6876yoN/b1 --logfile b1/build.log ksmbd-tools_3.5.3-1.dsc' - SUDO_GID='110' - SUDO_HOME='/var/lib/jenkins' - SUDO_UID='105' - SUDO_USER='jenkins' - TERM='unknown' - TZ='/usr/share/zoneinfo/Etc/GMT+12' - USER='root' - _='/usr/bin/systemd-run' - http_proxy='http://46.16.76.132:3128' + PWD=/ + SHELL=/bin/bash + SHELLOPTS=braceexpand:errexit:hashall:interactive-comments:posix + SHLVL=3 + SUDO_COMMAND='/usr/bin/timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice -n 11 /usr/bin/unshare --uts -- /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.C6876yoN/pbuilderrc_PYJv --distribution forky --hookdir /etc/pbuilder/rebuild-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/forky-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.C6876yoN/b2 --logfile b2/build.log ksmbd-tools_3.5.3-1.dsc' + SUDO_GID=110 + SUDO_HOME=/var/lib/jenkins + SUDO_UID=105 + SUDO_USER=jenkins + TERM=unknown + TZ=/usr/share/zoneinfo/Etc/GMT-14 + UID=0 + USER=root + _='I: set' + http_proxy=http://213.165.73.152:3128 I: uname -a - Linux ionos1-amd64 6.12.41+deb13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.41-1 (2025-08-12) x86_64 GNU/Linux + Linux i-capture-the-hostname 6.12.41+deb13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.41-1 (2025-08-12) x86_64 GNU/Linux I: ls -l /bin - lrwxrwxrwx 1 root root 7 Aug 10 12:30 /bin -> usr/bin -I: user script /srv/workspace/pbuilder/3848896/tmp/hooks/D02_print_environment finished + lrwxrwxrwx 1 root root 7 Aug 10 2025 /bin -> usr/bin +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/D02_print_environment finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy @@ -187,7 +219,7 @@ Get: 71 http://deb.debian.org/debian forky/main amd64 libnl-3-dev amd64 3.7.0-2 [101 kB] Get: 72 http://deb.debian.org/debian forky/main amd64 libnl-genl-3-200 amd64 3.7.0-2 [18.1 kB] Get: 73 http://deb.debian.org/debian forky/main amd64 libnl-genl-3-dev amd64 3.7.0-2 [17.6 kB] -Fetched 26.6 MB in 0s (129 MB/s) +Fetched 26.6 MB in 0s (138 MB/s) Preconfiguring packages ... Selecting previously unselected package libexpat1:amd64. (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading database ... 70% (Reading database ... 75% (Reading database ... 80% (Reading database ... 85% (Reading database ... 90% (Reading database ... 95% (Reading database ... 100% (Reading database ... 19855 files and directories currently installed.) @@ -436,8 +468,8 @@ Setting up tzdata (2025b-5) ... Current default time zone: 'Etc/UTC' -Local time is now: Fri Aug 29 06:59:09 UTC 2025. -Universal Time is now: Fri Aug 29 06:59:09 UTC 2025. +Local time is now: Thu Oct 1 13:23:18 UTC 2026. +Universal Time is now: Thu Oct 1 13:23:18 UTC 2026. Run 'dpkg-reconfigure tzdata' if you wish to change it. Setting up libsysprof-capture-4-dev:amd64 (48.0-2) ... @@ -507,7 +539,11 @@ Building tag database... -> Finished parsing the build-deps I: Building the package -I: Running cd /build/reproducible-path/ksmbd-tools-3.5.3/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-genchanges -S > ../ksmbd-tools_3.5.3-1_source.changes +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/A99_set_merged_usr starting +Not re-configuring usrmerge for forky +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/A99_set_merged_usr finished +hostname: Name or service not known +I: Running cd /build/reproducible-path/ksmbd-tools-3.5.3/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-genchanges -S > ../ksmbd-tools_3.5.3-1_source.changes dpkg-buildpackage: info: source package ksmbd-tools dpkg-buildpackage: info: source version 3.5.3-1 dpkg-buildpackage: info: source distribution unstable @@ -663,7 +699,7 @@ config.status: executing depfiles commands config.status: executing libtool commands dh_auto_build - make -j40 + make -j42 make[1]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3' make all-recursive make[2]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3' @@ -671,17 +707,6 @@ make[3]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3/addshare' gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/libnl3 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -pedantic -c -o share_admin.o share_admin.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/libnl3 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -pedantic -c -o addshare.o addshare.c -In file included from addshare.c:21: -addshare.c: In function 'addshare_main': -../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] - 125 | (f), \ - | ^~~ -../include/tools.h:132:9: note: in expansion of macro 'pr_log' - 132 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) - | ^~~~~~ -addshare.c:159:17: note: in expansion of macro 'pr_debug' - 159 | pr_debug("Can't send SIGHUP to PID %d: %m\n", - | ^~~~~~~~ share_admin.c: In function '__load_conf': share_admin.c:124:43: warning: non-ISO-standard escape sequence, '\e' 124 | printf("\r" "\e[2K" "%s%s" "\e[6n", option, buf); @@ -699,6 +724,17 @@ share_admin.c:154:29: warning: non-ISO-standard escape sequence, '\e' 154 | printf("\eM"); | ^ +In file included from addshare.c:21: +addshare.c: In function 'addshare_main': +../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] + 125 | (f), \ + | ^~~ +../include/tools.h:132:9: note: in expansion of macro 'pr_log' + 132 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) + | ^~~~~~ +addshare.c:159:17: note: in expansion of macro 'pr_debug' + 159 | pr_debug("Can't send SIGHUP to PID %d: %m\n", + | ^~~~~~~~ share_admin.c: In function 'new_conf_ml': share_admin.c:313:9: warning: enumeration value 'KSMBD_SHARE_CONF_COMMENT' not handled in switch [-Wswitch] 313 | switch (conf) { @@ -805,12 +841,12 @@ | ^~~~~~~~~ | | | char * -In file included from adduser.c:21: -adduser.c: In function 'adduser_main': In file included from user_admin.c:18: ../include/tools.h:142:36: note: expected 'unsigned char *' but argument is of type 'char *' 142 | char *base64_encode(unsigned char *src, size_t srclen); | ~~~~~~~~~~~~~~~^~~ +In file included from adduser.c:21: +adduser.c: In function 'adduser_main': ../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 125 | (f), \ | ^~~ @@ -1009,12 +1045,52 @@ ../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] 26 | unsigned char ____payload[0]; | ^~~~~~~~~~~ -rpc_srvsvc.c: In function 'srvsvc_parse_share_info_req': -rpc_srvsvc.c:310:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 310 | if (ndr_read_int32(dce, &ptr)) - | ^~~~ - | | - | int * +rpc.c: In function 'align_offset': +rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] + 91 | ({ \ + | ^ +rpc.c:224:23: note: in expansion of macro '__ALIGN' + 224 | dce->offset = __ALIGN(dce->offset, n); + | ^~~~~~~ +rpc.c: In function 'auto_align_offset': +rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] + 91 | ({ \ + | ^ +rpc.c:230:31: note: in expansion of macro '__ALIGN' + 230 | dce->offset = __ALIGN(dce->offset, 8); + | ^~~~~~~ +rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] + 91 | ({ \ + | ^ +rpc.c:232:31: note: in expansion of macro '__ALIGN' + 232 | dce->offset = __ALIGN(dce->offset, 4); + | ^~~~~~~ +rpc.c: At top level: +rpc.c:281:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 281 | NDR_WRITE_INT(int8, __u8, htobe_n, htole_n); + | ^ +rpc.c:282:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 282 | NDR_WRITE_INT(int16, __u16, htobe16, htole16); + | ^ +rpc_lsarpc.c: In function 'lsarpc_lookup_names3_invoke': +rpc.c:283:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 283 | NDR_WRITE_INT(int32, __u32, htobe32, htole32); + | ^ +rpc_lsarpc.c:444:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 444 | if (ndr_read_int32(dce, &num_names)) + | ^~~~~~~~~~ + | | + | int * +rpc.c:284:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 284 | NDR_WRITE_INT(int64, __u64, htobe64, htole64); + | ^ +In file included from rpc_lsarpc.c:16: +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ +rpc.c:305:44: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 305 | NDR_READ_INT(int8, __u8, betoh_n, letoh_n); + | ^ worker.c: In function 'login_request': worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ @@ -1022,34 +1098,55 @@ worker.c:49:13: note: in expansion of macro 'VALID_IPC_MSG' 49 | if (VALID_IPC_MSG(msg, struct ksmbd_login_request)) | ^~~~~~~~~~~~~ -In file included from rpc_srvsvc.c:16: -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ +rpc.c:306:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 306 | NDR_READ_INT(int16, __u16, be16toh, le16toh); + | ^ +rpc.c:307:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); + | ^ worker.c: In function 'login_request_ext': worker.c:88:51: warning: pointer targets in passing argument 1 of 'login_response_payload_sz' differ in signedness [-Wpointer-sign] 88 | payload_sz = login_response_payload_sz(req->account); | ~~~^~~~~~~~~ | | | __s8 * {aka signed char *} -rpc_srvsvc.c:329:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 329 | if (ndr_read_int32(dce, &hdr->level)) - | ^~~~~~~~~~~ - | | - | int * worker.c:61:44: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 61 | static int login_response_payload_sz(char *account) | ~~~~~~^~~~~~~ -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ | ^ worker.c:95:13: note: in expansion of macro 'VALID_IPC_MSG' 95 | if (VALID_IPC_MSG(msg, struct ksmbd_login_request)) | ^~~~~~~~~~~~~ +rpc_srvsvc.c: In function 'srvsvc_parse_share_info_req': +rpc.c:308:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 308 | NDR_READ_INT(int64, __u64, be64toh, le64toh); + | ^ +rpc_srvsvc.c:310:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 310 | if (ndr_read_int32(dce, &ptr)) + | ^~~~ + | | + | int * +In file included from rpc_srvsvc.c:16: +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ +rpc.c:329:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 329 | NDR_WRITE_UNION(int16, __u16); + | ^ +rpc.c:330:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 330 | NDR_WRITE_UNION(int32, __u32); + | ^ worker.c: In function 'spnego_authen_request': +rpc_srvsvc.c:329:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 329 | if (ndr_read_int32(dce, &hdr->level)) + | ^~~~~~~~~~~ + | | + | int * +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ worker.c:151:26: warning: pointer targets in passing argument 1 of 'strncpy' differ in signedness [-Wpointer-sign] 151 | strncpy(login_req.account, auth_out.user_name, | ~~~~~~~~~^~~~~~~~ @@ -1061,6 +1158,9 @@ /usr/include/x86_64-linux-gnu/bits/string_fortified.h:96:17: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 96 | __NTH (strncpy (__fortify_clang_overload_arg (char *, __restrict, __dest), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ +rpc.c:351:29: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 351 | NDR_READ_UNION(int32, __u32); + | ^ worker.c: In function 'tree_connect_request': worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ @@ -1084,32 +1184,30 @@ ../include/management/share.h:154:44: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 154 | struct ksmbd_share *shm_lookup_share(char *name); | ~~~~~~^~~~ -rpc_samr.c: In function 'samr_connect5_invoke': -worker.c: In function 'tree_disconnect_request': -rpc_samr.c:95:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 95 | if (ndr_read_int32(dce, &dce->sm_req.level)) - | ^~~~~~~~~~~~~~~~~~ +rpc.c: In function 'ndr_read_vstring': +rpc.c:524:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 524 | if (ndr_read_int32(dce, &raw_len)) + | ^~~~~~~~ | | | int * +In file included from mountd.c:22: +../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] + 26 | unsigned char ____payload[0]; + | ^~~~~~~~~~~ +worker.c: In function 'tree_disconnect_request': +rpc.c:287:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 287 | int ndr_read_##name(struct ksmbd_dcerpc *dce, type *value) \ + | ^ +rpc.c:307:1: note: in expansion of macro 'NDR_READ_INT' + 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); + | ^~~~~~~~~~~~ worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ | ^ worker.c:240:14: note: in expansion of macro 'VALID_IPC_MSG' 240 | if (!VALID_IPC_MSG(msg, struct ksmbd_tree_disconnect_request)) | ^~~~~~~~~~~~~ -In file included from rpc_samr.c:15: -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ worker.c: In function 'logout_request': -rpc_samr.c:100:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 100 | if (ndr_read_int32(dce, &dce->sm_req.client_version)) - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | int * -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ | ^ @@ -1123,104 +1221,6 @@ worker.c:259:14: note: in expansion of macro 'VALID_IPC_MSG' 259 | if (!VALID_IPC_MSG(msg, struct ksmbd_heartbeat)) | ^~~~~~~~~~~~~ -rpc_samr.c: In function 'samr_lookup_names_invoke': -rpc_samr.c:303:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 303 | if (ndr_read_int32(dce, &user_num)) - | ^~~~~~~~~ - | | - | int * -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ -rpc.c: In function 'align_offset': -rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] - 91 | ({ \ - | ^ -rpc.c:224:23: note: in expansion of macro '__ALIGN' - 224 | dce->offset = __ALIGN(dce->offset, n); - | ^~~~~~~ -rpc.c: In function 'auto_align_offset': -rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] - 91 | ({ \ - | ^ -rpc.c:230:31: note: in expansion of macro '__ALIGN' - 230 | dce->offset = __ALIGN(dce->offset, 8); - | ^~~~~~~ -rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] - 91 | ({ \ - | ^ -rpc.c:232:31: note: in expansion of macro '__ALIGN' - 232 | dce->offset = __ALIGN(dce->offset, 4); - | ^~~~~~~ -rpc.c: At top level: -rpc.c:281:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 281 | NDR_WRITE_INT(int8, __u8, htobe_n, htole_n); - | ^ -rpc.c:282:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 282 | NDR_WRITE_INT(int16, __u16, htobe16, htole16); - | ^ -rpc_wkssvc.c: In function 'wkssvc_parse_netwksta_info_req': -rpc_wkssvc.c:169:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 169 | if (ndr_read_int32(dce, &val)) - | ^~~~ - | | - | int * -In file included from rpc_wkssvc.c:16: -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ -rpc_samr.c: In function 'samr_query_security_return': -rpc.c:283:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 283 | NDR_WRITE_INT(int32, __u32, htobe32, htole32); - | ^ -rpc_samr.c:745:33: warning: pointer targets in passing argument 2 of 'build_sec_desc' differ in signedness [-Wpointer-sign] - 745 | if (build_sec_desc(dce, &sec_desc_len, ch->user->uid)) - | ^~~~~~~~~~~~~ - | | - | int * -In file included from ../include/rpc_samr.h:11, - from rpc_samr.c:16: -../include/smbacl.h:79:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 79 | int build_sec_desc(struct ksmbd_dcerpc *dce, __u32 *secdesclen, int rid); - | ~~~~~~~^~~~~~~~~~ -rpc.c:284:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 284 | NDR_WRITE_INT(int64, __u64, htobe64, htole64); - | ^ -rpc.c:305:44: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 305 | NDR_READ_INT(int8, __u8, betoh_n, letoh_n); - | ^ -rpc.c:306:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 306 | NDR_READ_INT(int16, __u16, be16toh, le16toh); - | ^ -rpc.c:307:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); - | ^ -rpc_lsarpc.c: In function 'lsarpc_lookup_names3_invoke': -rpc_lsarpc.c:444:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 444 | if (ndr_read_int32(dce, &num_names)) - | ^~~~~~~~~~ - | | - | int * -rpc.c:308:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 308 | NDR_READ_INT(int64, __u64, be64toh, le64toh); - | ^ -In file included from mountd.c:22: -../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] - 26 | unsigned char ____payload[0]; - | ^~~~~~~~~~~ -In file included from rpc_lsarpc.c:16: -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ -rpc.c:329:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 329 | NDR_WRITE_UNION(int16, __u16); - | ^ -rpc.c:330:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 330 | NDR_WRITE_UNION(int32, __u32); - | ^ -rpc.c:351:29: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 351 | NDR_READ_UNION(int32, __u32); - | ^ mountd.c: In function '__list_config_share_cb': mountd.c:66:70: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] 66 | dprintf(*wfd, LIST_FMT_SS "\n", share->name, share->comment ?: ""); @@ -1241,7 +1241,6 @@ mountd.c:136:17: note: in expansion of macro 'pr_err' 136 | pr_err("Can't control pipe: %m\n"); | ^~~~~~ -rpc.c: In function 'ndr_read_vstring': ../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 125 | (f), \ | ^~~ @@ -1251,17 +1250,6 @@ mountd.c:212:33: note: in expansion of macro 'pr_err' 212 | pr_err("Can't open `%s': %m\n", fifo_path); | ^~~~~~ -rpc.c:524:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 524 | if (ndr_read_int32(dce, &raw_len)) - | ^~~~~~~~ - | | - | int * -rpc.c:287:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 287 | int ndr_read_##name(struct ksmbd_dcerpc *dce, type *value) \ - | ^ -rpc.c:307:1: note: in expansion of macro 'NDR_READ_INT' - 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); - | ^~~~~~~~~~~~ mountd.c: In function 'worker_init': ../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 125 | (f), \ @@ -1282,6 +1270,7 @@ 244 | pr_err("Can't fork worker: %m\n"); | ^~~~~~ mountd.c: In function 'manager_init': +rpc_samr.c: In function 'samr_connect5_invoke': ../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 125 | (f), \ | ^~~ @@ -1291,6 +1280,15 @@ mountd.c:354:25: note: in expansion of macro 'pr_err' 354 | pr_err("Can't fork manager: %m\n"); | ^~~~~~ +rpc_samr.c:95:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 95 | if (ndr_read_int32(dce, &dce->sm_req.level)) + | ^~~~~~~~~~~~~~~~~~ + | | + | int * +In file included from rpc_samr.c:15: +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ ../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 125 | (f), \ | ^~~ @@ -1300,6 +1298,14 @@ mountd.c:365:25: note: in expansion of macro 'pr_err' 365 | pr_err("Can't redirect stream: %m\n"); | ^~~~~~ +rpc_samr.c:100:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 100 | if (ndr_read_int32(dce, &dce->sm_req.client_version)) + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | int * +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ ../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 125 | (f), \ | ^~~ @@ -1314,16 +1320,36 @@ 420 | nodetach = !optarg ?: cp_get_group_kv_long(optarg); | ^ mountd.c:420:45: warning: the omitted middle operand in '?:' will always be 'true', suggest explicit middle operand [-Wparentheses] +rpc_samr.c: In function 'samr_lookup_names_invoke': +rpc_samr.c:303:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 303 | if (ndr_read_int32(dce, &user_num)) + | ^~~~~~~~~ + | | + | int * +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ In file included from ipc.c:21: ../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] 26 | unsigned char ____payload[0]; | ^~~~~~~~~~~ +rpc_samr.c: In function 'samr_query_security_return': ipc.c: In function 'ipc_ksmbd_starting_up': +rpc_samr.c:745:33: warning: pointer targets in passing argument 2 of 'build_sec_desc' differ in signedness [-Wpointer-sign] + 745 | if (build_sec_desc(dce, &sec_desc_len, ch->user->uid)) + | ^~~~~~~~~~~~~ + | | + | int * ipc.c:154:27: warning: pointer targets in passing argument 1 of 'strncpy' differ in signedness [-Wpointer-sign] 154 | strncpy(ev->min_prot, | ~~^~~~~~~~~~ | | | __s8 * {aka signed char *} +In file included from ../include/rpc_samr.h:11, + from rpc_samr.c:16: +../include/smbacl.h:79:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 79 | int build_sec_desc(struct ksmbd_dcerpc *dce, __u32 *secdesclen, int rid); + | ~~~~~~~^~~~~~~~~~ In file included from /usr/include/features.h:523, from /usr/include/memory.h:25, from ipc.c:8: @@ -1380,6 +1406,16 @@ ipc.c:217:25: note: in expansion of macro 'pr_err' 217 | pr_err("Can't wait on netlink socket: %m\n"); | ^~~~~~ +rpc_wkssvc.c: In function 'wkssvc_parse_netwksta_info_req': +rpc_wkssvc.c:169:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 169 | if (ndr_read_int32(dce, &val)) + | ^~~~ + | | + | int * +In file included from rpc_wkssvc.c:16: +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ rm -f libmountd.a ar cr libmountd.a worker.o ipc.o rpc.o rpc_srvsvc.o rpc_wkssvc.o mountd.o smbacl.o rpc_samr.o rpc_lsarpc.o ranlib libmountd.a @@ -1396,20 +1432,35 @@ ../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] 26 | unsigned char ____payload[0]; | ^~~~~~~~~~~ -management/share.c: In function 'shm_share_name': -management/share.c:130:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 130 | is_name = cp_printable(name) && *name != '[' && *name != ']'; - | ^~~~ - | | - | char * -In file included from management/share.c:17: +config_parser.c: In function 'is_a_key_value': +config_parser.c:106:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 106 | is_key_value = cp_printable(entry) && !cp_smbconf_eol(entry); + | ^~~~~ + | | + | char * +In file included from config_parser.c:17: ../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' 25 | static inline int cp_printable(unsigned char *p) | ~~~~~~~~~~~~~~~^ -management/user.c: In function 'new_ksmbd_user': -management/user.c:125:20: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign] - 125 | user->pass = base64_decode(user->pass_b64, &pass_sz); - | ^ +config_parser.c:121:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 121 | is_key_value = cp_printable(entry); + | ^~~~~ + | | + | char * +../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' + 25 | static inline int cp_printable(unsigned char *p) + | ~~~~~~~~~~~~~~~^ +In file included from config_parser.c:18: +config_parser.c: In function '__mmap_parse_file': +../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] + 125 | (f), \ + | ^~~ +../include/tools.h:132:9: note: in expansion of macro 'pr_log' + 132 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) + | ^~~~~~ +config_parser.c:221:17: note: in expansion of macro 'pr_debug' + 221 | pr_debug("Can't open `%s': %m\n", path); + | ^~~~~~~~ management/tree_conn.c: In function 'tcm_handle_tree_connect': management/tree_conn.c:65:37: warning: pointer targets in passing argument 1 of 'shm_lookup_share' differ in signedness [-Wpointer-sign] 65 | share = shm_lookup_share(req->share); @@ -1420,6 +1471,9 @@ ../include/management/share.h:154:44: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 154 | struct ksmbd_share *shm_lookup_share(char *name); | ~~~~~~^~~~ +config_parser.c:246:54: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] + 246 | delim = memchr(contents, '\n', len) ?: contents + len; + | ^ management/tree_conn.c:87:39: warning: pointer targets in passing argument 3 of 'shm_lookup_hosts_map' differ in signedness [-Wpointer-sign] 87 | req->peer_addr); | ~~~^~~~~~~~~~~ @@ -1428,6 +1482,7 @@ ../include/management/share.h:172:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 172 | char *host); | ~~~~~~^~~~ +management/user.c: In function 'new_ksmbd_user': management/tree_conn.c:97:47: warning: pointer targets in passing argument 3 of 'shm_lookup_hosts_map' differ in signedness [-Wpointer-sign] 97 | req->peer_addr); | ~~~^~~~~~~~~~~ @@ -1436,16 +1491,9 @@ ../include/management/share.h:172:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 172 | char *host); | ~~~~~~^~~~ -management/user.c: In function 'usm_user_name': -management/user.c:222:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 222 | is_name = cp_printable(name) && *name != ':'; - | ^~~~ - | | - | char * -In file included from management/user.c:18: -../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' - 25 | static inline int cp_printable(unsigned char *p) - | ~~~~~~~~~~~~~~~^ +management/user.c:125:20: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign] + 125 | user->pass = base64_decode(user->pass_b64, &pass_sz); + | ^ management/tree_conn.c:143:35: warning: pointer targets in passing argument 1 of 'usm_lookup_user' differ in signedness [-Wpointer-sign] 143 | user = usm_lookup_user(req->account); | ~~~^~~~~~~~~ @@ -1463,6 +1511,12 @@ ../include/management/share.h:168:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 168 | char *name); | ~~~~~~^~~~ +management/user.c: In function 'usm_user_name': +management/user.c:222:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 222 | is_name = cp_printable(name) && *name != ':'; + | ^~~~ + | | + | char * management/tree_conn.c:166:39: warning: pointer targets in passing argument 3 of 'shm_lookup_users_map' differ in signedness [-Wpointer-sign] 166 | req->account); | ~~~^~~~~~~~~ @@ -1471,6 +1525,10 @@ ../include/management/share.h:168:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 168 | char *name); | ~~~~~~^~~~ +In file included from management/user.c:18: +../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' + 25 | static inline int cp_printable(unsigned char *p) + | ~~~~~~~~~~~~~~~^ management/tree_conn.c:175:39: warning: pointer targets in passing argument 3 of 'shm_lookup_users_map' differ in signedness [-Wpointer-sign] 175 | req->account); | ~~~^~~~~~~~~ @@ -1479,10 +1537,7 @@ ../include/management/share.h:168:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 168 | char *name); | ~~~~~~^~~~ -management/user.c: In function 'usm_update_user_password': -management/user.c:318:22: warning: pointer targets in initialization of 'char *' from 'unsigned char *' differ in signedness [-Wpointer-sign] - 318 | char *pass = base64_decode(pass_b64, &pass_sz); - | ^~~~~~~~~~~~~ +config_parser.c: In function 'steal_global_share_conf_kv': management/tree_conn.c:184:39: warning: pointer targets in passing argument 3 of 'shm_lookup_users_map' differ in signedness [-Wpointer-sign] 184 | req->account); | ~~~^~~~~~~~~ @@ -1499,6 +1554,16 @@ ../include/management/share.h:168:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 168 | char *name); | ~~~~~~^~~~ +config_parser.c:589:44: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] + 589 | k ?: KSMBD_SHARE_CONF[c], + | ^ +management/user.c: In function 'usm_update_user_password': +config_parser.c:590:44: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] + 590 | v ?: KSMBD_SHARE_DEFCONF[c]); + | ^ +management/user.c:318:22: warning: pointer targets in initialization of 'char *' from 'unsigned char *' differ in signedness [-Wpointer-sign] + 318 | char *pass = base64_decode(pass_b64, &pass_sz); + | ^~~~~~~~~~~~~ management/user.c: In function '__handle_login_request': management/user.c:383:46: warning: pointer targets in passing argument 2 of 'usm_copy_user_passhash' differ in signedness [-Wpointer-sign] 383 | resp->hash, @@ -1513,45 +1578,30 @@ | ~~~~^~~~~~~~~ | | | __s8 * {aka signed char *} -management/share.c: In function 'shm_handle_share_config_request': management/user.c:352:40: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 352 | char *account, | ~~~~~~^~~~~~~ management/user.c: In function 'usm_handle_login_request': -management/share.c:937:21: warning: pointer targets in passing argument 1 of 'strncat' differ in signedness [-Wpointer-sign] - 937 | strncat(resp->share_name, share->name, KSMBD_REQ_MAX_SHARE_NAME - 1); - | ~~~~^~~~~~~~~~~~ - | | - | __s8 * {aka signed char *} management/user.c:406:43: warning: pointer targets in passing argument 1 of 'usm_lookup_user' differ in signedness [-Wpointer-sign] 406 | user = usm_lookup_user(req->account); | ~~~^~~~~~~~~ | | | __s8 * {aka signed char *} -In file included from /usr/include/features.h:523, - from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, - from /usr/include/stdlib.h:26, - from management/share.c:8: -/usr/include/x86_64-linux-gnu/bits/string_fortified.h:145:17: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} - 145 | __NTH (strncat (__fortify_clang_overload_arg (char *, __restrict, __dest), - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ management/user.c:183:42: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 183 | struct ksmbd_user *usm_lookup_user(char *name) | ~~~~~~^~~~ +management/share.c: In function 'shm_share_name': +management/share.c:130:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 130 | is_name = cp_printable(name) && *name != '[' && *name != ']'; + | ^~~~ + | | + | char * management/user.c: In function 'usm_handle_login_request_ext': -config_parser.c: In function 'is_a_key_value': -config_parser.c:106:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 106 | is_key_value = cp_printable(entry) && !cp_smbconf_eol(entry); - | ^~~~~ - | | - | char * -management/share.c:946:24: warning: pointer targets in assignment from '__s8 *' {aka 'signed char *'} to 'unsigned char *' differ in signedness [-Wpointer-sign] - 946 | config_payload = KSMBD_SHARE_CONFIG_VETO_LIST(resp); - | ^ -In file included from config_parser.c:17: +In file included from management/share.c:17: ../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' 25 | static inline int cp_printable(unsigned char *p) | ~~~~~~~~~~~~~~~^ +config_parser.c: In function 'cp_parse_subauth': management/user.c:440:35: warning: pointer targets in passing argument 1 of 'usm_lookup_user' differ in signedness [-Wpointer-sign] 440 | user = usm_lookup_user(req->account); | ~~~^~~~~~~~~ @@ -1560,14 +1610,34 @@ management/user.c:183:42: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 183 | struct ksmbd_user *usm_lookup_user(char *name) | ~~~~~~^~~~ -config_parser.c:121:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 121 | is_key_value = cp_printable(entry); - | ^~~~~ - | | - | char * -../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' - 25 | static inline int cp_printable(unsigned char *p) - | ~~~~~~~~~~~~~~~^ +config_parser.c:872:43: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] + 872 | contents ?: "", + | ^ +management/user.c: In function 'usm_handle_logout_request': +management/user.c:455:35: warning: pointer targets in passing argument 1 of 'usm_lookup_user' differ in signedness [-Wpointer-sign] + 455 | user = usm_lookup_user(req->account); + | ~~~^~~~~~~~~ + | | + | __s8 * {aka signed char *} +management/user.c:183:42: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} + 183 | struct ksmbd_user *usm_lookup_user(char *name) + | ~~~~~~^~~~ +management/share.c: In function 'shm_handle_share_config_request': +management/share.c:937:21: warning: pointer targets in passing argument 1 of 'strncat' differ in signedness [-Wpointer-sign] + 937 | strncat(resp->share_name, share->name, KSMBD_REQ_MAX_SHARE_NAME - 1); + | ~~~~^~~~~~~~~~~~ + | | + | __s8 * {aka signed char *} +In file included from /usr/include/features.h:523, + from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, + from /usr/include/stdlib.h:26, + from management/share.c:8: +/usr/include/x86_64-linux-gnu/bits/string_fortified.h:145:17: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} + 145 | __NTH (strncat (__fortify_clang_overload_arg (char *, __restrict, __dest), + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ +management/share.c:946:24: warning: pointer targets in assignment from '__s8 *' {aka 'signed char *'} to 'unsigned char *' differ in signedness [-Wpointer-sign] + 946 | config_payload = KSMBD_SHARE_CONFIG_VETO_LIST(resp); + | ^ management/share.c:954:25: warning: pointer targets in passing argument 1 of 'sprintf' differ in signedness [-Wpointer-sign] 954 | sprintf(config_payload, | ^~~~~~~~~~~~~~ @@ -1576,49 +1646,15 @@ /usr/include/x86_64-linux-gnu/bits/stdio2.h:28:1: note: expected 'char *' but argument is of type 'unsigned char *' 28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...)) | ^~~~~ -management/user.c: In function 'usm_handle_logout_request': management/share.c:959:25: warning: pointer targets in passing argument 1 of 'sprintf' differ in signedness [-Wpointer-sign] 959 | sprintf(config_payload, "%s", share->path); | ^~~~~~~~~~~~~~ | | | unsigned char * -management/user.c:455:35: warning: pointer targets in passing argument 1 of 'usm_lookup_user' differ in signedness [-Wpointer-sign] - 455 | user = usm_lookup_user(req->account); - | ~~~^~~~~~~~~ - | | - | __s8 * {aka signed char *} /usr/include/x86_64-linux-gnu/bits/stdio2.h:28:1: note: expected 'char *' but argument is of type 'unsigned char *' 28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...)) | ^~~~~ -management/user.c:183:42: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} - 183 | struct ksmbd_user *usm_lookup_user(char *name) - | ~~~~~~^~~~ -In file included from config_parser.c:18: -config_parser.c: In function '__mmap_parse_file': -../include/tools.h:125:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] - 125 | (f), \ - | ^~~ -../include/tools.h:132:9: note: in expansion of macro 'pr_log' - 132 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) - | ^~~~~~ -config_parser.c:221:17: note: in expansion of macro 'pr_debug' - 221 | pr_debug("Can't open `%s': %m\n", path); - | ^~~~~~~~ -config_parser.c:246:54: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] - 246 | delim = memchr(contents, '\n', len) ?: contents + len; - | ^ -config_parser.c: In function 'steal_global_share_conf_kv': -config_parser.c:589:44: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] - 589 | k ?: KSMBD_SHARE_CONF[c], - | ^ -config_parser.c:590:44: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] - 590 | v ?: KSMBD_SHARE_DEFCONF[c]); - | ^ -config_parser.c: In function 'cp_parse_subauth': -config_parser.c:872:43: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] - 872 | contents ?: "", - | ^ -/bin/bash ../libtool --tag=CC --mode=link gcc -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -pedantic -Wl,-z,relro -Wl,-z,now -o ksmbd.tools management/tree_conn.o management/user.o management/share.o management/session.o config_parser.o tools.o ../addshare/libaddshare.a ../adduser/libadduser.a ../control/libcontrol.a ../mountd/libmountd.a -lglib-2.0 -lnl-genl-3 -lnl-3 +/bin/sh ../libtool --tag=CC --mode=link gcc -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -pedantic -Wl,-z,relro -Wl,-z,now -o ksmbd.tools management/tree_conn.o management/user.o management/share.o management/session.o config_parser.o tools.o ../addshare/libaddshare.a ../adduser/libadduser.a ../control/libcontrol.a ../mountd/libmountd.a -lglib-2.0 -lnl-genl-3 -lnl-3 libtool: link: gcc -DSYSCONFDIR=\"/etc\" -DRUNSTATEDIR=\"/run\" -I../include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.3=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -pedantic -Wl,-z -Wl,relro -Wl,-z -Wl,now -o ksmbd.tools management/tree_conn.o management/user.o management/share.o management/session.o config_parser.o tools.o ../addshare/libaddshare.a ../adduser/libadduser.a ../control/libcontrol.a ../mountd/libmountd.a -lglib-2.0 -lnl-genl-3 -lnl-3 -pthread make[3]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.3/tools' make[3]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3' @@ -1626,7 +1662,7 @@ make[2]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.3' make[1]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.3' dh_auto_test - make -j40 check "TESTSUITEFLAGS=-j40 --verbose" VERBOSE=1 + make -j42 check "TESTSUITEFLAGS=-j42 --verbose" VERBOSE=1 make[1]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3' Making check in addshare make[2]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3/addshare' @@ -1724,7 +1760,7 @@ make[2]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3/tools' make[3]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.3/tools' /usr/bin/mkdir -p '/build/reproducible-path/ksmbd-tools-3.5.3/debian/ksmbd-tools/usr/libexec' - /bin/bash ../libtool --mode=install /usr/bin/install -c ksmbd.tools '/build/reproducible-path/ksmbd-tools-3.5.3/debian/ksmbd-tools/usr/libexec' + /bin/sh ../libtool --mode=install /usr/bin/install -c ksmbd.tools '/build/reproducible-path/ksmbd-tools-3.5.3/debian/ksmbd-tools/usr/libexec' libtool: install: /usr/bin/install -c ksmbd.tools /build/reproducible-path/ksmbd-tools-3.5.3/debian/ksmbd-tools/usr/libexec/ksmbd.tools make[3]: Nothing to be done for 'install-data-am'. make[3]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.3/tools' @@ -1759,8 +1795,8 @@ dh_gencontrol dh_md5sums dh_builddeb -dpkg-deb: building package 'ksmbd-tools' in '../ksmbd-tools_3.5.3-1_amd64.deb'. dpkg-deb: building package 'ksmbd-tools-dbgsym' in '../ksmbd-tools-dbgsym_3.5.3-1_amd64.deb'. +dpkg-deb: building package 'ksmbd-tools' in '../ksmbd-tools_3.5.3-1_amd64.deb'. dpkg-genbuildinfo --build=binary -O../ksmbd-tools_3.5.3-1_amd64.buildinfo dpkg-genchanges --build=binary -O../ksmbd-tools_3.5.3-1_amd64.changes dpkg-genchanges: info: binary-only upload (no source code included) @@ -1768,12 +1804,14 @@ dpkg-buildpackage: info: binary-only upload (no source included) dpkg-genchanges: info: including full source code in upload I: copying local configuration +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/B01_cleanup starting +I: user script /srv/workspace/pbuilder/2160172/tmp/hooks/B01_cleanup finished I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env -I: removing directory /srv/workspace/pbuilder/3848896 and its subdirectories -I: Current time: Thu Aug 28 18:59:47 -12 2025 -I: pbuilder-time-stamp: 1756450787 +I: removing directory /srv/workspace/pbuilder/2160172 and its subdirectories +I: Current time: Fri Oct 2 03:23:40 +14 2026 +I: pbuilder-time-stamp: 1790861020