Skip to content
Success

Changes

Summary

  1. drop FTCBFS patch #1038165 fixed in c-ares/1.19.1-3 (details)
  2. drop fixup #1035521 applied in gcc-defaults/1.206 (details)
  3. improve usage of dpkg-architecture (details)
  4. drop -Wno-error MR applied to glibc/2.37-3 (details)
  5. unconditionally apply patch_gcc_has_include_next (details)
  6. fix p11-kit FTCBFS #1040472 (details)
  7. increase shellcheck happiness (details)
  8. drop FTCBFS patch #1040472 fixed in p11-kit/0.25.0-3 (details)
Commit 990e6346692f51e58e557036beae72870f04fe54 by Helmut Grohne
drop FTCBFS patch #1038165 fixed in c-ares/1.19.1-3

This reverts commit 242bc43b7bf646090df0fb2e7a330796096c4e74.
The file was modified bootstrap.sh
Commit ab8232f820d174e54fa269457a5c10360854431b by Helmut Grohne
drop fixup #1035521 applied in gcc-defaults/1.206
The file was modified bootstrap.sh
Commit b80a6b900f743582c3ebb9bd29494959c2b9e66c by Helmut Grohne
improve usage of dpkg-architecture

* Properly quote arguments, which also makes shellcheck a little
   happier.
* Use the -i flag rather than matching its output.
* When in a hook, prefer the hook argument as architecture.
The file was modified bootstrap.sh
Commit f8e69b4edcf5e763d75f23a759383a44ec2c4f80 by Helmut Grohne
drop -Wno-error MR applied to glibc/2.37-3
The file was modified bootstrap.sh
Commit 7b6b07bfa607abea2da0f7aaeb34c758c03e4f37 by Helmut Grohne
unconditionally apply patch_gcc_has_include_next

gcc-12 builds started failing in stage1 while compiling libgcov-merge.c
due to missing <sys/mman.h>. That header is only available in glibc
stage2, so the issue is that HAVE_SYS_MMAN_H is defined. That happens,
because the relevant configure check erroneously succeeds by using
/lib/cpp rather than the correct cpp invocation. cpp is misdetected,
because the correct cpp failed #including <limits.h>, because our
patched __has_include_next(<limits.h>) produces an error, which is gcc
bug 80755 and is fixed by this very patch. A subtle change in include
directory order made this patch important and the failure came three
layers later.
The file was modified bootstrap.sh
Commit 5b53c9cc178e4dda2c5ebbc22aad03c4846ca211 by Helmut Grohne
fix p11-kit FTCBFS #1040472
The file was modified bootstrap.sh
Commit cacf3bf31cd1ecffb4e44db9e4a902242964c8a6 by Helmut Grohne
increase shellcheck happiness

These are relatively obvious fixes that e.g. improve compatibility with
bash, add missing quoting or use idiomatic computations.

What remains for shellcheck largely is style remarks and false
positives. For instance, we excessively modify variables in subshells to
intentionally get those changes reverted. Likewise, using variables in
single-quoted strings is not a mistake. In order to address the globbing
issues, more architectural changes would be necessary.
The file was modified bootstrap.sh
Commit 6d277d0c968663c13ad463cd94429589bf311f14 by Helmut Grohne
drop FTCBFS patch #1040472 fixed in p11-kit/0.25.0-3
The file was modified bootstrap.sh